From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A87DB1F8C6 for ; Wed, 28 Jul 2021 11:30:04 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9023B399201B for ; Wed, 28 Jul 2021 11:30:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9023B399201B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627471803; bh=iT2wGFR3Fkh8PUvHhRXFubr+NkWTTZ1W8MyGbiPJqBw=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=woVaACylRkkMZioENku843u7hwXmKmd3ZEPPSfyuGSDXh8t79SLVnSWOikxlyp9J0 6txCNDuL6mfnLJIiaz3gLN7KEDdq+9LX+eU6O7lI47sDWrUWnwGErGlHTtLDfdViHu mVnFHhJH8gx/MEH7yJgUSQQyKktYaVGOiJoUOBS0= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id E4F553990C33 for ; Wed, 28 Jul 2021 11:25:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E4F553990C33 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-383-eXPz93aPOrWicSTTnLO-9w-1; Wed, 28 Jul 2021 07:25:20 -0400 X-MC-Unique: eXPz93aPOrWicSTTnLO-9w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2EA18DF8A0; Wed, 28 Jul 2021 11:25:19 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-7.ams2.redhat.com [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5606660BD9; Wed, 28 Jul 2021 11:25:18 +0000 (UTC) To: Siddhesh Poyarekar Subject: Re: [PATCH v2] xmalloc: Fix warnings with gcc analyzer References: <20210728103345.4065595-1-siddhesh@sourceware.org> <87sfzy8zcv.fsf@oldenburg.str.redhat.com> <6285ea15-68a1-38a0-712c-f47188275951@sourceware.org> Date: Wed, 28 Jul 2021 13:25:16 +0200 In-Reply-To: <6285ea15-68a1-38a0-712c-f47188275951@sourceware.org> (Siddhesh Poyarekar's message of "Wed, 28 Jul 2021 16:53:34 +0530") Message-ID: <87o8am8yub.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Siddhesh Poyarekar: > On 7/28/21 4:44 PM, Florian Weimer via Libc-alpha wrote: >> * Siddhesh Poyarekar: >> >>> extern void *xrealloc (void *o, size_t n) >>> + __attribute_malloc__ __attribute_alloc_size__ ((2)) __attr_dealloc_free >>> + __returns_nonnull; >> Sorry, this one has again __returns_nonnull for xrealloc. > > The xrealloc in programs does a malloc(1) if the size requested is 0, > so it never really returns a NULL. So it does not free anything ever? We should not have two different attributes for xrealloc. I suggest to drop the attribute from the include/* version for now, until we can clean this up. Thanks, Florian