From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 46CF81F9F4 for ; Thu, 18 Nov 2021 13:23:33 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 422FF3857C5F for ; Thu, 18 Nov 2021 13:23:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 422FF3857C5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637241812; bh=tghjJOiVhgVvxCm362oRt368BsK0AKUVDDhHSRtYtXQ=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hWU6npj6z3XuXdgA4EOtUkJolXodq2K/l0P5GxD3DozqssEbySC/n6d3f0R7NG3nO yFyCrdvn7fqCHhW6XZoZFKvrKpXpDn+wz1sS0z8gb4MWNCYLAD8pWFGZVEMtfvoUOK djlTNRUOFZMgiCJATQFaaxX9WPb7IH8tbWJcve14= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0E6ED385843A for ; Thu, 18 Nov 2021 13:23:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0E6ED385843A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-454-9l-LDfRoM2OJUPiH-f4jlA-1; Thu, 18 Nov 2021 08:23:10 -0500 X-MC-Unique: 9l-LDfRoM2OJUPiH-f4jlA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AD71E83DEBD; Thu, 18 Nov 2021 13:23:09 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.131]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A55E19730; Thu, 18 Nov 2021 13:23:07 +0000 (UTC) To: Jakub Jelinek Subject: Re: [PATCH 1/3] nptl: Extract from pthread_cond_common.c References: <20211118131902.GA2646553@tucnak> Date: Thu, 18 Nov 2021 14:23:06 +0100 In-Reply-To: <20211118131902.GA2646553@tucnak> (Jakub Jelinek's message of "Thu, 18 Nov 2021 14:19:02 +0100") Message-ID: <87o86hha2t.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: gcc-patches@gcc.gnu.org, libc-alpha@sourceware.org, Jason Merrill Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Jakub Jelinek: > On Wed, Nov 03, 2021 at 05:27:42PM +0100, Florian Weimer wrote: >> + /* S3. See __condvar_load_64_relaxed. */ > > Shouldn't that be See __atomic_wide_counter_load_relaxed ? I'm going to fix the stale reference, thanks. >> + if (((l >> 31) > 0) && ((h >> 31) > 0)) > > Any reason not to write it as (int) l < 0 && (int) h < 0? This requires a GCC extension (which active by default, even without -fwrapv). Obviously we relay on this extension in many other place, but still =E2=80=A6 Thanks, Florian