From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 58F821F85E for ; Fri, 13 Jul 2018 20:00:58 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=r74cHGXpe0iQKVNzAlApO1wA+/P/jxkLQnrNfyYvZ/b mogXFPvbTVV3ThXDO+rY+l/21LOSMHdmquYlxXveXjVNUxNH8HqX5H6Jd56s0nxr CmU620Kzhd+5CB/Xz35YSiABTBnty05o0JvO4tZ7V0qsUhyDB7YrT3jVsEuQ3M3Y = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=WIOI9z7lNP8T9XYROy+xOFw83eI=; b=H0UpaaI3vkcJuDRMq 03xW7NFTj5dWT62+whB7vGnWbToXGLMWPZ2UpV/kzej2YZDp/D5Rvk6HmcBA7HNG nyFZShbRA0EPnUTd4t9YHjVXlfq46hVWMTfNn4LCOlb/p28BKlaoNq7iP17lpZzm aC7osfuac7RNonWv+y/mcgx8ik= Received: (qmail 69557 invoked by alias); 13 Jul 2018 20:00:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 69376 invoked by uid 89); 13 Jul 2018 20:00:37 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: albireo.enyo.de From: Florian Weimer To: Adhemerval Zanella Cc: Florian Weimer , libc-alpha@sourceware.org Subject: Re: [PATCH v8 6/8] nptl: Add abilist symbols for C11 threads References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-7-git-send-email-adhemerval.zanella@linaro.org> <97b42cb3-e76a-ac71-65cd-c1f6d8c404aa@redhat.com> <90dc04ab-81df-b0d7-a086-d00ea5cc979d@linaro.org> <5ec19a17-30a3-e9b7-9475-c28b247c8daa@redhat.com> <98a36756-5dc8-680b-c065-3501ca4ec7d4@linaro.org> Date: Fri, 13 Jul 2018 21:56:51 +0200 In-Reply-To: <98a36756-5dc8-680b-c065-3501ca4ec7d4@linaro.org> (Adhemerval Zanella's message of "Fri, 13 Jul 2018 15:47:43 -0300") Message-ID: <87muuuc3jw.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable * Adhemerval Zanella: >> I think ONCE_FLAG_INIT needs to be a compound literal, not an >> initializer, at least that's how I read the standard (=E2=80=9Cwhich exp= ands >> to a value that can be used to initialize an object=E2=80=9D). > > Right, you are correct, this will prevent ONCE_FLAG_INIT to be wrongly=20 > used to initialize other objects than once_flag. I adjust to be a=20 > struct as well. Sorry, I forgot that this needs another __cplusplus conditional. Something like this: #ifdef __cplusplus # define ONCE_FLAG_INIT (once_flag {}) #else # define ONCE_FLAG_INIT (once_flag) { 0 } #endif Compound literals in C++ are a GCC extension. >>> =C2=A0=C2=A0 - thread_local guards for C++. >>=20 >> Missing indentation of the #define.=C2=A0 The manual could mention that >> for C++, C++11 or later needs to be used to get the thread_local >> keyword (not the macro). > > Ack and I added a note on manual about C++11 requirement. Thanks.