From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3F8481F45E for ; Tue, 18 Feb 2020 18:07:21 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=XtZJT07auR7iLko2QWmsybN0x9tib2B9yI3K4XoDgpU VPgpMz090lPaUY110qcE23b4KlaS9sA+ecEMM3oda9vma/LDNmrQ7NnG2Zf+vjI5 ybrlR3/VLxcIl3GxUFB8H9YFJKNBwOpCl0npOc/4aMMIECz5c9WrQOPLBmNGOLvM = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=3fFo5x9e9KaHO6GQy1gD8uvf00Y=; b=wPDFhWJ9fVcl9yyYI i7uo2r+sX/9tyx/w/NsUlroBTARhNfokRsIttkQvza/LP94s3qH9xhkzkl5YjffF yTH1oivOtbSI3vGk1cy0PJPqZXQqL1mLGHG6MjF2xHlHKMWu2mnNBSsD+340Q+Mz 3ODkwhq6FAlTzHL9iAzm9sku+Y= Received: (qmail 94825 invoked by alias); 18 Feb 2020 18:07:19 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 94817 invoked by uid 89); 18 Feb 2020 18:07:18 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-delivery-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582049236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CnE3HAD4Vw3/Xg5jaEkGOznhYhjFTjMk2vsXm1YCvgQ=; b=droQhybpwfXZWo8A0mvqw3eUo8hv7v2ZdodQ1reswkMVu9OsmsZteHmNUoznxIVwKHDcan EMMV2DB1Imj82p+QwOS8CnHETs54/cbII+sjeBhySA3JaT78y5Ru01A7XJn5tVHVIZa9CR FXVq0WKhpG38UDzaigXeQZgfCk8614c= From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 1/3] support: Add support_process_state_wait References: <20200218140205.18263-1-adhemerval.zanella@linaro.org> <87k14jzzz0.fsf@oldenburg2.str.redhat.com> <87r1yrye69.fsf@oldenburg2.str.redhat.com> <3d881d3a-e817-0a7b-314d-a9626f1660fa@linaro.org> Date: Tue, 18 Feb 2020 19:07:06 +0100 In-Reply-To: <3d881d3a-e817-0a7b-314d-a9626f1660fa@linaro.org> (Adhemerval Zanella's message of "Tue, 18 Feb 2020 15:01:18 -0300") Message-ID: <87mu9fydkl.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable * Adhemerval Zanella: > On 18/02/2020 14:54, Florian Weimer wrote: >> * Adhemerval Zanella: >>=20 >>>> I think it would be clearer to use ferror to check for errors. >>> >>> Maybe:=20 >>> >>> if (ret =3D=3D -1 || ferror (stream)) >>> ... >>> >>> ? >>=20 >> I think you might get ret =3D=3D -1 on EOF, too. > > Indeed, so: > > if (!feof (stream) && ferror (stream)) > FAIL_EXIT1 ("getline failed: %m"); > > Should cover it. Yes, I think so. Thanks, Florian