From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 151EE1F8C6 for ; Wed, 28 Jul 2021 08:11:15 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9E499398CC0D for ; Wed, 28 Jul 2021 08:11:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9E499398CC0D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627459872; bh=391dlNhQgVhjcvaPpgOXT/hjwsPc48BcNvssaULdVcM=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OSMZcgfzFh8SyA8hudNybketHIk5WPKUIt5G2ZeEdaBFHdZNr6W+qCLqFcZGWIjIY T3/ycP2hUUkPXGA8h6745m6Rbpa9DsV/F55BEzVzYWAWdyu5oLn7pdXxwIcX0xJKfD JEOoTSR8AWfzmxD5hpcGgoP9IM5sVjKKBElc7Dyo= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 2E9713987007 for ; Wed, 28 Jul 2021 07:14:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2E9713987007 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-210-VIbNIDITMfSHpDLhgMptNw-1; Wed, 28 Jul 2021 03:14:45 -0400 X-MC-Unique: VIbNIDITMfSHpDLhgMptNw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B3CC08799E0; Wed, 28 Jul 2021 07:14:44 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-7.ams2.redhat.com [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DB5F85DD86; Wed, 28 Jul 2021 07:14:43 +0000 (UTC) To: Siddhesh Poyarekar via Libc-alpha Subject: Re: [PATCH] __cxa_thread_atexit_impl: Return -1 on allocation failure References: <20210728062522.3904733-1-siddhesh@sourceware.org> Date: Wed, 28 Jul 2021 09:14:41 +0200 In-Reply-To: <20210728062522.3904733-1-siddhesh@sourceware.org> (Siddhesh Poyarekar via Libc-alpha's message of "Wed, 28 Jul 2021 11:55:22 +0530") Message-ID: <87mtq6ap0e.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: Siddhesh Poyarekar Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Siddhesh Poyarekar via Libc-alpha: > Return -1 in the unlikely event that allocation fails when trying to > register a TLS destructor. This is bug 18524. As said on the bug, the interface is broken. We really need to rework C++ global destructor support so that these dynamic memory allocations become unnecessary. The GCC-generated caller code does not check the return value (and could do anything with it anyway). You probable need to add __libc_fatal. Thanks, Florian