From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AC73A1F462 for ; Tue, 21 May 2019 13:06:28 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=OBi8C 8kecpLTo4ibzKJj1WM1FFc9xwoKtHH8iDUqxdIcXJg8zd/r4pykh+tt5r2wq9cYD xmENYJXsDsYCeiqGlhAmHIhpj/SGMiTtsP+o/qmdQYTralmisXucR4yRW1FZEfs6 V3nf7MvFCBAwgPR2pGz0ywoIYxjc6JthmHuVEA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=qqDIxnmQ+cM 2GLvYRYySmR1GAZo=; b=vlAmfFQ9bwKVHPLzodoNuT5JXFwjmPLx471D5baezxx KU0hH90pNiA/6UyIMJL+jDTQ5I2xnbsOSWWU48FGXgtUaXkgYc5LpZQTAOOCDqrF Cdqfz4F7RVmciYFkceJZMLLW/9xeru8kShOJd3S4sKX/nt4AdUTp/PARO7VOdLeU = Received: (qmail 48755 invoked by alias); 21 May 2019 13:06:26 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 48746 invoked by uid 89); 21 May 2019 13:06:25 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: DJ Delorie Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH References: Date: Tue, 21 May 2019 15:06:21 +0200 In-Reply-To: (DJ Delorie's message of "Tue, 21 May 2019 08:49:08 -0400") Message-ID: <87lfz09ctu.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain * DJ Delorie: > Florian Weimer writes: >> Should we perhaps start with an environment that contains just PATH, and >> add all the *-ENV variables (but not LOCPATH and GCONV_PATH)? > > I hate to put in a "full clean environment" option because we don't know > what environment variables the user might have set intentionally for > running the testsuite (distcc, for example). But I see the benefit of > sanitizing the environment, both from the usual environment and from the > command line. Sorry, I don't understand. Why would the user want to run distcc *in the container*? What reason do we have to believe that the host environment variable settings (regarding terminal, locales and the like) are even valid in the container? Thanks, Florian