From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9AB4C1F461 for ; Tue, 3 Sep 2019 13:32:12 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=oTX6N 6wsH1HPyMSQ7f5d9BBcHld87Uk5mmuMWUTJt3oJMFrwf2ARTj2RmpQ36sUOs/gza riNv6MPtp1bR0vuzdsThO52sUVTJo3Tx5m7mqu+FszPLM1rUHTCwN1Ea/le7B8Md jC8ryeGiQbo4XSLybLJF52c0lJMyTqvFWYRBDw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=hfTCoNZdd13 hpiWbI10qtZwwlY4=; b=Fbj4p+1J27U3HJbSSgfBfk81vyXtWgTnKNoSGPfCZAZ 8r6pbAm4nlrisYcvAbPLUIO3D5yEKJtO2yDJyDt3Kjh5EJSIrmT0wDdnd1aIp3Dr f/EWFcw5vChTzvcU1cM6h9aIDJc8c859b0WYuFksVDELp7GVgiXxiYeTA2tUq8W8 = Received: (qmail 24488 invoked by alias); 3 Sep 2019 13:31:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 24424 invoked by uid 89); 3 Sep 2019 13:31:45 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: Adhemerval Zanella Cc: Zack Weinberg , libc-alpha@sourceware.org, Joseph Myers , Lukasz Majewski , Alistair Francis , Stepan Golosunov , Arnd Bergmann , Samuel Thibault Subject: Re: [PATCH v2 02/10] Finish move of clock_* functions to libc. References: <20190828153236.18229-1-zackw@panix.com> <20190828153236.18229-3-zackw@panix.com> <87h85tu9bp.fsf@oldenburg2.str.redhat.com> <2bd7b653-e698-73c7-72b0-4e90c4b08d7a@linaro.org> Date: Tue, 03 Sep 2019 15:31:36 +0200 In-Reply-To: <2bd7b653-e698-73c7-72b0-4e90c4b08d7a@linaro.org> (Adhemerval Zanella's message of "Tue, 3 Sep 2019 10:25:28 -0300") Message-ID: <87lfv5qzev.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain * Adhemerval Zanella: > On 03/09/2019 04:29, Florian Weimer wrote: >> * Zack Weinberg: >> >>> diff --git a/rt/Versions b/rt/Versions >>> index 91e3fd2a20..84d1345420 100644 >>> --- a/rt/Versions >>> +++ b/rt/Versions >>> @@ -1,15 +1,3 @@ >>> -libc { >>> - GLIBC_2.17 { >>> - # c* >>> - clock_getres; clock_gettime; clock_settime; clock_getcpuclockid; >>> - clock_nanosleep; >>> - } >>> - GLIBC_PRIVATE { >>> - __clock_getres; __clock_gettime; __clock_settime; __clock_getcpuclockid; >>> - __clock_nanosleep; >>> - } >>> -} >> >> Sorry, you cannot remove the GLIBC_2.17 symbol version in this way, >> otherwise old binaries will fail to load. You need to leave behind a >> dummy function definition. See __libpthread_version_placeholder for how >> I handled this in the libpthread/vfork case. > > Are you sure about it? Yes. 8-) But I missed that this block was just moved to time/Versions. Either place will work and generate the same symbol versions. For librt proper, the problem does not arise because sem_open is still present at the same symbol version, keeping the version present and alive. Zack, please disregard my comment about rt/Versions. Thanks, Florian