From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5ECA71F45E for ; Wed, 19 Feb 2020 10:34:32 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=Jy/xOIMdH9RfcbdlM54pRS9P5Y5H7CJ5IftCkd3Yuvq gnKKBoZ2r3fZ56JXWfkE/aLTQCxC6BdceJ1QDYvBad/yZRd8GK4r1rIm/PBHZAgJ kRYxYu0O6Tm7lNNaflqFGg7tdBbZxVMDRV3+EyWcMrpWvLOkmwknsvJ+acLfxuxE = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=zeaVmk/QLECiZdNIYeTtFPsMSHY=; b=fMW6ndKRyMKf9U7KU 4Mfy/ZZ4QoMJ6ROBs3qcW3yOV2HUvhf/eSDUJ4HE++JTK0oa0Gh4ZIe218U0p5c8 2E72Ms6OH4G4hWr++vz7tRycH5XO9izwUERDRUnYL8G094FBxmviaXPVsLpL3qZu J1DBsHtfh2hT473QXsXNs3ppm4= Received: (qmail 38914 invoked by alias); 19 Feb 2020 10:34:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 38905 invoked by uid 89); 19 Feb 2020 10:34:29 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-delivery-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582108466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uMG+Lo7TDxeO9qmAOmb5Ut7sfm3YagQqBcK7ZLK7ZY0=; b=ZvUhvwqH/xNu73gHjupggQnF6WnDFjkcb50BMwd+T41oE8sZyfsHyyIrccEDL1AvLwoEnN ACct4THp5UfzHkBBRmVsUWnCiA5V40dQNSzY2NEdNFTEjYz0kgXClomEMT4IT4ExfSuwhE f6lBAPqwNSdssNit52nxgxL7A+zvqqQ= From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v4] Block all signals on timer_create thread (BZ#10815) References: <20200218171946.12426-1-adhemerval.zanella@linaro.org> Date: Wed, 19 Feb 2020 11:34:21 +0100 In-Reply-To: <20200218171946.12426-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Tue, 18 Feb 2020 14:19:46 -0300") Message-ID: <87lfoydfwy.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable * Adhemerval Zanella: > diff --git a/nptl/tst-cancel28.c b/nptl/tst-cancel28.c > new file mode 100644 > index 0000000000..f126dd8bcb > --- /dev/null > +++ b/nptl/tst-cancel28.c > +/* A stall in cancellation is a regression. */ > +#define TIMEOUT 5 > +#include I don't think we should reduce the test timeout below the default. > diff --git a/rt/tst-timer-sigmask.c b/rt/tst-timer-sigmask.c > new file mode 100644 > index 0000000000..1ed60e9d85 > --- /dev/null > +++ b/rt/tst-timer-sigmask.c > +#ifdef __linux__ > + /* POSIX timers threads created to handle SIGEV_THREAD block all > +=09 signals except SIGKILL, SIGSTOP and glibc internals one except > +=09 SIGTIMER. */ > + if (!sigismember (&ss, sig) > +=09 && (sig !=3D SIGSETXID && sig !=3D SIGCANCEL > +=09 && sig !=3D SIGKILL && sig !=3D SIGSTOP)) > +=09{ > +=09 thread_handler_failure =3D true; I think you can use TEST_VERIFY here. Then you won't need the thread_handler_failure variable. > +=09} > +#endif Is __linux__ really the right conditional to check here? Rest of the patch looks okay. Thanks, Florian