From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5D7341F55B for ; Mon, 1 Jun 2020 18:43:31 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7B516386F41D; Mon, 1 Jun 2020 18:43:30 +0000 (GMT) Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21]) by sourceware.org (Postfix) with ESMTPS id 5B7593851C36 for ; Mon, 1 Jun 2020 18:43:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5B7593851C36 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=deneb.enyo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de Received: from [172.17.203.2] (helo=deneb.enyo.de) by albireo.enyo.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1jfpPC-0003oG-FY; Mon, 01 Jun 2020 18:43:26 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.92) (envelope-from ) id 1jfpPC-0007It-Bo; Mon, 01 Jun 2020 20:43:26 +0200 From: Florian Weimer To: Adhemerval Zanella Subject: Re: [PATCH 05/13] string: Remove old TLS usage on strsignal References: <20200519180518.318733-1-adhemerval.zanella@linaro.org> <20200519180518.318733-6-adhemerval.zanella@linaro.org> <87y2pccmsj.fsf@oldenburg2.str.redhat.com> <4ead5141-c6ba-3fde-d30c-872a1024dfd1@linaro.org> <87tuzuwt5m.fsf@mid.deneb.enyo.de> Date: Mon, 01 Jun 2020 20:43:26 +0200 In-Reply-To: (Adhemerval Zanella's message of "Mon, 1 Jun 2020 15:39:16 -0300") Message-ID: <87lfl6wrsh.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Weimer , Adhemerval Zanella via Libc-alpha Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" * Adhemerval Zanella: > My confusion in fact, this is another issue indeed. I added it just > to follow the small optimization dony by __strerror_thread_freeres > to avoid pulling the free code on static usage. Yes, it requires a separate fix (eventually, not this series). > So do you think it would be better to just call free on > __libc_thread_freeres (it should be ok since code initializes it to > NULL)? If so, maybe also do the same for __strerror_thread_freeres? Yes, if it is just a free call that only pulls in malloc, that should be okay.