From: Andreas Schwab <schwab@linux-m68k.org>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Florian Weimer <fw@deneb.enyo.de>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Revert "linux: Move {f}xstat{at} to compat symbols" for static build
Date: Thu, 21 Jan 2021 10:21:22 +0100 [thread overview]
Message-ID: <87lfcmtzl9.fsf@igel.home> (raw)
In-Reply-To: <20201229194929.130589-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Tue, 29 Dec 2020 16:49:29 -0300")
On Dez 29 2020, Adhemerval Zanella wrote:
> diff --git a/sysdeps/mach/hurd/fxstat.c b/sysdeps/mach/hurd/fxstat.c
> index 3201bb8cf1..e7e4b6e65e 100644
> --- a/sysdeps/mach/hurd/fxstat.c
> +++ b/sysdeps/mach/hurd/fxstat.c
> @@ -19,9 +19,6 @@
> #include <stddef.h>
> #include <sys/stat.h>
> #include <hurd.h>
> -#include <shlib-compat.h>
> -
> -#if SHLIB_COMPAT(libc, GLIBC_2_0, GLIBC_2_33)
>
> /* Get information about the file descriptor FD in BUF. */
> int
> @@ -33,5 +30,3 @@ __fxstat (int vers, int fd, struct stat *buf)
> return __fstat (fd, buf);
> }
> weak_alias (__fxstat, _fxstat)
> -
> -#endif
Should this use LIB_COMPAT?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2021-01-21 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 19:49 [PATCH] Revert "linux: Move {f}xstat{at} to compat symbols" for static build Adhemerval Zanella via Libc-alpha
2021-01-20 16:52 ` Adhemerval Zanella via Libc-alpha
2021-01-20 18:03 ` Florian Weimer via Libc-alpha
2021-01-20 18:28 ` Adhemerval Zanella via Libc-alpha
2021-01-21 9:21 ` Andreas Schwab [this message]
2021-01-21 16:41 ` Adhemerval Zanella via Libc-alpha
2021-01-21 17:04 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfcmtzl9.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=adhemerval.zanella@linaro.org \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).