From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 072D11F488 for ; Wed, 8 May 2019 15:00:43 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=cdAi0 TpMW4xlplQjczWla6XVOpq0TxUhRWHefKks7e+pakyYSrGhl5cnWQj+T48c3OPHj 3SFLWhIKQdmJmrldOYIdjZzORj5eM/Hzeo5ksQk772DdQuld13iyig9ZThCOsV5W GcY5xn8arAksKBSWB8E9Y70sAgjrUH3TzP7ZXc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=Ff4VmYaH+hh bT+gob1rfD4XIimk=; b=SRDi04So8LNf9flPC+zNqE/3KhPQ7K949Lp0ma07dRn /H57Ek160UwXURj2lluz6j++3u0dtelKQN7O9FM/0/aJlYUDeZFWRqw+wWC5cM2Y +pn+fio3e/ZAq5KQ47oPFTrCQP5yqgibjPii9r6dCTmEf94Z4JDPRfyFLEt0zzk4 = Received: (qmail 38268 invoked by alias); 8 May 2019 15:00:40 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 38259 invoked by uid 89); 8 May 2019 15:00:40 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: Mike Crowe Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 1/5] support: Add xclock_gettime References: <87ef59xdmf.fsf@oldenburg2.str.redhat.com> <20190508142220.6pfy44weefmbdn5r@mcrowe.com> Date: Wed, 08 May 2019 17:00:36 +0200 In-Reply-To: <20190508142220.6pfy44weefmbdn5r@mcrowe.com> (Mike Crowe's message of "Wed, 8 May 2019 15:22:20 +0100") Message-ID: <87k1f1vvmz.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain * Mike Crowe: > On Wednesday 08 May 2019 at 15:46:48 +0200, Florian Weimer wrote: >> * Mike Crowe: >> > * support/xclock_gettime.c (xclock_gettime): New file. Provide >> > clock_gettime wrapper for use in tests that fails the test rather >> > than returning failure. >> > >> > * support/xtime.h: New file to declare xclock_gettime. >> > >> > * support/Makefile: Add xclock_gettime.c. >> > >> > * support/README: Mention xtime.h. >> >> Patch looks good, but the commit message above looks a bit odd (I mean >> the indentation). > > I just copied and pasted from the ChangeLog entry, so each line starts with > a tab. This seems to be quite common looking through the existing history > (e.g. 52faba65f84ee5a8d82ff813bcfa0ee5f4d480cf) but I can reformat it to > remove the tab if required. I could also add some explanatory text before > the ChangeLog entry if you think that would be better. Something ate the first tab character, on the initial line. I've fixed it. (I don't think it's Zimbra's fault, it's missing in the web archives as well.) >> Do you have an account on sourceware? If yes, please push this >> independently of the rest. > > No, I do not. Okay, I've pushed it for you. Thanks, Florian