From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 608401F461 for ; Wed, 17 Jul 2019 05:33:32 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=WH6gC erl97AHKkeFqlxEUoN3FalzV3efORCfa9J6MAHIBIYEG7YkokNpGBF+wN0bPou3W iyu/po4hLED+EWaybnjtkxr4nmQC01Zu5U4E7fMEqj6vC7zmRsjHiLqABN8Aka6t lb8Qi5TcVCNW65f4X+a4zlaYjiM9YJU+A3Bzms= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=IoqFgTyiCMw LoUgW3Cv6+vANj+M=; b=mXjO9MWFoje9OJ4ARdoM1ENHkcupoWqKl5+fLz68aX+ GawSV/EFGKHjEqZqM0RizI2dL+SI4kiyG/1758oXRuV4DqQKXqyTm9I0SM57C2sr ICmchZKWy86sYR/xIStSezF11oj361A5l4HJHpGSpt0Lz9IRzaND+tZY/u/FPPqk = Received: (qmail 99989 invoked by alias); 17 Jul 2019 05:33:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 99976 invoked by uid 89); 17 Jul 2019 05:33:30 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: Alistair Francis Cc: libc-alpha@sourceware.org, arnd@arndb.de, adhemerval.zanella@linaro.org, palmer@sifive.com, macro@wdc.com, zongbox@gmail.com, alistair23@gmail.com Subject: Re: [RFC v3 23/23] RISC-V: Use 64-bit vdso syscalls References: <2bf63d1fc37727b7ed77dd20a69ae525a0cee859.1563321716.git.alistair.francis@wdc.com> Date: Wed, 17 Jul 2019 07:33:24 +0200 In-Reply-To: <2bf63d1fc37727b7ed77dd20a69ae525a0cee859.1563321716.git.alistair.francis@wdc.com> (Alistair Francis's message of "Tue, 16 Jul 2019 17:09:42 -0700") Message-ID: <87k1chdy3f.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain * Alistair Francis: > Signed-off-by: Alistair Francis > --- > sysdeps/unix/sysv/linux/riscv/init-first.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sysdeps/unix/sysv/linux/riscv/init-first.c b/sysdeps/unix/sysv/linux/riscv/init-first.c > index 155a4a2c0c..fa9c690cdd 100644 > --- a/sysdeps/unix/sysv/linux/riscv/init-first.c > +++ b/sysdeps/unix/sysv/linux/riscv/init-first.c > @@ -43,11 +43,11 @@ _libc_vdso_platform_setup (void) > PTR_MANGLE (p); > VDSO_SYMBOL (gettimeofday) = p; > > - p = _dl_vdso_vsym ("__vdso_clock_gettime", &linux_version); > + p = _dl_vdso_vsym ("__vdso_clock_gettime64", &linux_version); > PTR_MANGLE (p); > VDSO_SYMBOL (clock_gettime) = p; > > - p = _dl_vdso_vsym ("__vdso_clock_getres", &linux_version); > + p = _dl_vdso_vsym ("__vdso_clock_getres_time64", &linux_version); > PTR_MANGLE (p); > VDSO_SYMBOL (clock_getres) = p; > } I believe this will lose vDSO acceleration for RV64 on older kernels which do not define __vdso_clock_getres_time64. Thanks, Florian