Re: [PATCH] statfs: add missing f_flags assignment

[Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>]

* Chen Li:

> f_flags is added into struct statfs since Linux 2.6.36, which is lacked
> in glibc's statfs64.c until now. So mount flags is uninitialized on
> platforms having no statfs64 syscall in kernel, e.g., alpha and its derivation
>
> Signed-off-by: chenli <chenli@uniontech.com>
> ---
>  sysdeps/unix/sysv/linux/statfs64.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sysdeps/unix/sysv/linux/statfs64.c b/sysdeps/unix/sysv/linux/statfs64.c
> index c941128637..2c293badc8 100644
> --- a/sysdeps/unix/sysv/linux/statfs64.c
> +++ b/sysdeps/unix/sysv/linux/statfs64.c
> @@ -78,6 +78,7 @@ __statfs64 (const char *file, struct statfs64 *buf)
>    buf->f_fsid = buf32.f_fsid;
>    buf->f_namelen = buf32.f_namelen;
>    buf->f_frsize = buf32.f_frsize;
> +  buf->f_flags = buf32.f_flags;
>    memcpy (buf->f_spare, buf32.f_spare, sizeof (buf32.f_spare));
>  
>    return 0;

I've checked that this builds on all architectures.

Does this result in a user-visible bug on some architectures besides
alpha?

May we drop the “Signed-off-by: chenli <chenli@uniontech.com>” line?
glibc does not use DCO <https://developercertificate.org/>, but due to
the size of the change, no additional paperwork is required for this
contribution.

Thanks,
Florian
-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill