From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 52AAC1F4B5 for ; Wed, 13 Nov 2019 06:18:12 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=CqfxK i9yizJ376LfcQ2I8+X411y4J+cfdqUMCVomdV5wHwE+hgRFKwsFsohtKbRhJxaM5 nyi/a2KNQopzyOs9utcN9ozFUk9E/GRwXp6hoLWmlBsmFknEWaPm4hBqAInAuVVk FjfHmnOFkZgpApec5k4Zfo3ndZWK00RUq/74JM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=XMTm2UcQiz1 5H674fHoQ1A+7E9g=; b=ELvr1kWATj17Cl2MzWm+pLEr4KgOU16MXTe74LLJJTr GUvcV/ruzY9H9SMPY+xPP23rKIIbtKsVK7BCvnTf1miZaom5YCXs+bqw4VShJs29 wftBW6x+olMOqKs4knM3/voVNMDA7e3wL5TiWAJdlhhlqqxmRkpFeZckN2SkaFuE = Received: (qmail 31832 invoked by alias); 13 Nov 2019 06:18:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 31820 invoked by uid 89); 13 Nov 2019 06:18:09 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: albireo.enyo.de From: Florian Weimer To: Joseph Myers Cc: Carlos O'Donell , Sandra Loosemore , Florian Weimer , , Szabolcs Nagy , , Subject: Re: [review v3] slotinfo in struct dtv_slotinfo_list should be flexible array [BZ #25... References: <20191112114732.2175B20AF6@gnutoolchain-gerrit.osci.io> <4e7ad8ea-43ae-6af6-d2a9-2a05d42b0cc6@codesourcery.com> <87r22dey2c.fsf@mid.deneb.enyo.de> <320362b6-854f-230e-5db8-af20f66ef838@redhat.com> <87sgmsbuxn.fsf@mid.deneb.enyo.de> <9bf19b9d-1af1-c830-37e5-cadb06a2b0df@redhat.com> Date: Wed, 13 Nov 2019 07:18:00 +0100 In-Reply-To: (Joseph Myers's message of "Tue, 12 Nov 2019 22:39:04 +0000") Message-ID: <87imno9u5j.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain * Joseph Myers: > On Tue, 12 Nov 2019, Carlos O'Donell wrote: > >> >> How long will that take and is it OK to leave things in a broken >> >> state for that long for a given target like nios2? >> > >> > Maybe we should back the fix out and see how quickly we can get in the >> > other GCC 10 patches? >> >> I'd like to hear Joseph's opinion on this. > > I think the GCC fix ought to be backported to GCC 8 and 9 branches (and > generically that applies to fixes relevant to building new glibc versions > - or to building GCC *with* new glibc versions, sometimes that can justify > e.g. selective backports of libsanitizer fixes where new glibc broke it). > > I don't think we have a basis for backing out this change from glibc at > this point. However, if people wish to fix building with GCC 10 on > previous glibc release branches (and such fixes have been a common class > of glibc patch backports in the past - evidently some people do wish to > build glibc release branches with GCC versions that postdate those glibc > releases), perhaps it would be better for the release-branch fix just to > disable the warning in the affected file rather than backporting the fix > from master. It should be possible to write a configure check for the GCC bug and build the affected object with -mgpopt=none, since it's a local issue concentrated to a single object. Or we can add -mgpopt=none unconditionally for the time being.