From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 930061F55B for ; Thu, 28 May 2020 11:56:33 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7CEB7388B01B; Thu, 28 May 2020 11:56:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7CEB7388B01B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1590666989; bh=h1M64mwow8/w71hHpFAptwDl1IWDOQllASyTMkvXhgY=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=naxHsORE+02foql5k/mjiV2sMpxkkxjTok8UEp3wftvLSSXYN/OurAYoVD8Xshn/9 iwD0Q0qB2A3y2tMVIj6GGrVbVBMnfo6BBwr7NrrB/k+Rbq9lWhT5l4kLkNXeUMKZrS FJn6j5GXQZUz0P5BXMuLI9cQQOk1vznB3aP234zU= Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 14742386F430 for ; Thu, 28 May 2020 11:56:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 14742386F430 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-246-PTWu3YA2MsOI37wbeNTuuw-1; Thu, 28 May 2020 07:56:25 -0400 X-MC-Unique: PTWu3YA2MsOI37wbeNTuuw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 38EF68014D7; Thu, 28 May 2020 11:56:24 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-91.ams2.redhat.com [10.36.112.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8748E19D7C; Thu, 28 May 2020 11:56:23 +0000 (UTC) To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 08/13] string: Simplify strerror_r References: <20200519180518.318733-1-adhemerval.zanella@linaro.org> <20200519180518.318733-9-adhemerval.zanella@linaro.org> Date: Thu, 28 May 2020 13:56:21 +0200 In-Reply-To: <20200519180518.318733-9-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 19 May 2020 15:05:13 -0300") Message-ID: <87imggcly2.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" * Adhemerval Zanella via Libc-alpha: > Use snprintf instead of mempcpy plus itoa_word and remove unused > definitions. Given that this is not performance-critical at all, this looks good to me. There is no potential for infinite recursion because snprintf only use strerror_r for the %m specifier. Thanks, Florian