* [PATCH v2] tst: Provide test for timerfd related functions
@ 2021-01-13 23:14 Lukasz Majewski
2021-01-14 12:03 ` Florian Weimer via Libc-alpha
0 siblings, 1 reply; 2+ messages in thread
From: Lukasz Majewski @ 2021-01-13 23:14 UTC (permalink / raw
To: Joseph Myers, Adhemerval Zanella
Cc: Florian Weimer, GNU C Library, Florian Weimer, Alistair Francis
This change adds new test to assess functionality of timerfd_*
functions.
It creates new timer (operates on its file descriptor) and checks
if time before and after sleep is between expected values.
---
Changes for v2:
- Provide extra space before opening '(' in function calls and
definitions
- Use the xclose instead of close
- Remove the abs(diff) call
- Refactor the code to replace tabs with spaces
---
sysdeps/unix/sysv/linux/Makefile | 3 +-
sysdeps/unix/sysv/linux/tst-timerfd.c | 96 +++++++++++++++++++++++++++
2 files changed, 98 insertions(+), 1 deletion(-)
create mode 100644 sysdeps/unix/sysv/linux/tst-timerfd.c
diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile
index 6df4779126..7503b356c8 100644
--- a/sysdeps/unix/sysv/linux/Makefile
+++ b/sysdeps/unix/sysv/linux/Makefile
@@ -107,7 +107,8 @@ tests += tst-clone tst-clone2 tst-clone3 tst-fanotify tst-personality \
tst-quota tst-sync_file_range tst-sysconf-iov_max tst-ttyname \
test-errno-linux tst-memfd_create tst-mlock2 tst-pkey \
tst-rlimit-infinity tst-ofdlocks tst-gettid tst-gettid-kill \
- tst-tgkill tst-sysvsem-linux tst-sysvmsg-linux tst-sysvshm-linux
+ tst-tgkill tst-sysvsem-linux tst-sysvmsg-linux tst-sysvshm-linux \
+ tst-timerfd
tests-internal += tst-ofdlocks-compat tst-sigcontext-get_pc
CFLAGS-tst-sigcontext-get_pc.c = -fasynchronous-unwind-tables
diff --git a/sysdeps/unix/sysv/linux/tst-timerfd.c b/sysdeps/unix/sysv/linux/tst-timerfd.c
new file mode 100644
index 0000000000..bf64a39d5a
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/tst-timerfd.c
@@ -0,0 +1,96 @@
+/* Test for timerfd related functions
+ Copyright (C) 2021 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include <time.h>
+#include <support/check.h>
+#include <support/xunistd.h>
+#include <sys/time.h>
+#include <sys/timerfd.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <unistd.h>
+
+static int
+do_test (void)
+{
+ struct itimerspec settings = { { 2, 0 }, { 2, 0 } };
+ struct itimerspec val1, val2;
+ int fd, ret;
+
+ fd = timerfd_create (CLOCK_REALTIME, 0);
+ if (fd < 0)
+ {
+ FAIL_EXIT1 ("*** timerfd_create %d failed: %m", fd);
+ }
+
+ /* Set the timer. */
+ ret = timerfd_settime (fd, 0, &settings, NULL);
+ if (ret != 0)
+ {
+ printf ("*** timerfd_settime failed: %m\n");
+ goto err;
+ }
+
+ /* Read the timer just before sleep. */
+ ret = timerfd_gettime (fd, &val1);
+ if (ret != 0)
+ {
+ printf ("*** timerfd_gettime failed: %m\n");
+ goto err;
+ }
+
+ /* Sleep for 1 second. */
+ ret = usleep (1000000);
+ if (ret != 0)
+ {
+ printf ("*** usleep failed: %m\n");
+ goto err;
+ }
+
+ /* Read the timer just after sleep. */
+ ret = timerfd_gettime (fd, &val2);
+ if (ret != 0)
+ {
+ printf ("*** timerfd_gettime failed: %m\n");
+ goto err;
+ }
+
+ /* Check difference between timerfd_gettime() calls. */
+ long long int diff = val2.it_value.tv_sec - val1.it_value.tv_sec;
+ diff *= 1000000000;
+ diff += val2.it_value.tv_nsec - val1.it_value.tv_nsec;
+ /* Subtrack time we have been sleeping (1s). */
+ diff -= 1000000000;
+
+ if (diff > 100000000)
+ {
+ printf ("*** The diff between timerfd calls (%lld) is wrong!\n",
+ diff);
+ goto err;
+ }
+
+ xclose(fd);
+
+ return 0;
+
+ err:
+ xclose (fd);
+ return ret;
+}
+
+#include <support/test-driver.c>
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] tst: Provide test for timerfd related functions
2021-01-13 23:14 [PATCH v2] tst: Provide test for timerfd related functions Lukasz Majewski
@ 2021-01-14 12:03 ` Florian Weimer via Libc-alpha
0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer via Libc-alpha @ 2021-01-14 12:03 UTC (permalink / raw
To: Lukasz Majewski
Cc: GNU C Library, Florian Weimer, Alistair Francis, Joseph Myers
* Lukasz Majewski:
> +static int
> +do_test (void)
> +{
> + struct itimerspec settings = { { 2, 0 }, { 2, 0 } };
> + struct itimerspec val1, val2;
> + int fd, ret;
> +
> + fd = timerfd_create (CLOCK_REALTIME, 0);
> + if (fd < 0)
> + {
> + FAIL_EXIT1 ("*** timerfd_create %d failed: %m", fd);
> + }
The braces are unncessary.
> + /* Set the timer. */
> + ret = timerfd_settime (fd, 0, &settings, NULL);
> + if (ret != 0)
> + {
> + printf ("*** timerfd_settime failed: %m\n");
> + goto err;
> + }
Please use FAIL_EXIT1 throughout. This is not merely a style issue: As
written, ret is not a valid return value for do_test.
> + /* Check difference between timerfd_gettime() calls. */
No () after function names.
> + xclose(fd);
Missing space before parenthesis.
Thanks,
Florian
--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-14 12:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-13 23:14 [PATCH v2] tst: Provide test for timerfd related functions Lukasz Majewski
2021-01-14 12:03 ` Florian Weimer via Libc-alpha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).