From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 738DA1F45E for ; Thu, 13 Feb 2020 08:12:34 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=kwwHhoG6P5/JcAi5MWo1gUBTywlB+ehJ8TPaeyV4A8j lR31jjYSe6Db0mxTESoP3YuqEWC/MXfh+CKmkA1taDyK4H3qiBAElzmzwocVjGSF aZreurcrMWB1Dx3dGoflSdb6kYM9c9260BZR4j4JYmDZjfYiS1DPWi+PLZzsfmj0 = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=xuoSefAqS4BAMuRdIr5/IT+QDbo=; b=xSpPvG0qUnpXE/2LY IEZvtvAAFktufGPUEV4SytqMbw3Peuax0e0VfJDbxkkSF+fVLtiMPs1XQBYwZVrw urnME2mIn4KkWC8qK0csSMH0GceNseSNDoqh1gDRqhQxTNACzuuVJHk5Bl38CHFo +Efi7SPEtSOzmrsMzpONEzh9+E= Received: (qmail 9987 invoked by alias); 13 Feb 2020 08:12:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 9845 invoked by uid 89); 13 Feb 2020 08:12:20 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581581537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0ej160kNE437RmJ9G3NnE4AdsvWERDGR9ACd9IHiUNY=; b=LQneztAXrMa7Y2CEi+i7SRj2slym69l/PKyK95RAZCcVgqI/qyHgzE6/g1Q9xNQLDBsunN f/9AIBhjnf9/Tq9J/98l8HTNq6Gbh7pEHmEaVW1HQitT1RSIesNFqAJ4JOEGcCx94NJL++ KgJ6MaV5S1kFheu5qzgpkYGxhSFP6qU= From: Florian Weimer To: DJ Delorie Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 6/7] nss_files: Use NSS_DECLARE_MODULE_FUNCTIONS References: Date: Thu, 13 Feb 2020 09:12:11 +0100 In-Reply-To: (DJ Delorie's message of "Wed, 12 Feb 2020 20:26:35 -0500") Message-ID: <87h7zudhyc.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable * DJ Delorie: > Florian Weimer writes: >> nss/nss_files/files-alias.c | 2 ++ >> nss/nss_files/files-ethers.c | 3 +++ >> nss/nss_files/files-grp.c | 3 +++ >> nss/nss_files/files-hosts.c | 2 ++ >> nss/nss_files/files-init.c | 3 +++ >> nss/nss_files/files-initgroups.c | 3 +++ >> nss/nss_files/files-key.c | 2 ++ >> nss/nss_files/files-netgrp.c | 2 ++ >> nss/nss_files/files-network.c | 3 +++ >> nss/nss_files/files-proto.c | 2 ++ >> nss/nss_files/files-pwd.c | 3 +++ >> nss/nss_files/files-rpc.c | 2 ++ >> nss/nss_files/files-service.c | 2 ++ >> nss/nss_files/files-sgrp.c | 3 +++ >> nss/nss_files/files-spwd.c | 3 +++ >> 15 files changed, 38 insertions(+) > > LGTM. Seems to be some inconsistency about whether to use or > "nsswitch.h" - I wonder if always using "nsswitch.h" *just* for > consistency would be worth the cost? > > Reviewed-by: DJ Delorie Maybe we should add nss_files.h if there any common declarations? Thanks, Florian