From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 703E01F8C6 for ; Mon, 2 Aug 2021 13:30:33 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B09863839821 for ; Mon, 2 Aug 2021 13:30:32 +0000 (GMT) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id A599F385743B for ; Mon, 2 Aug 2021 13:29:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A599F385743B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Gdf491mWzz1s9N2; Mon, 2 Aug 2021 15:29:29 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Gdf491YwQz1qwYd; Mon, 2 Aug 2021 15:29:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 93kzwhExf0_5; Mon, 2 Aug 2021 15:29:28 +0200 (CEST) X-Auth-Info: M1xmHHADB75N0RFuVs5qGuqrkMj3aLDCxv3Df6lSIgyEzd0VSCmq/wiyzJAxkGxL Received: from igel.home (ppp-46-244-161-54.dynamic.mnet-online.de [46.244.161.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 2 Aug 2021 15:29:28 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id A77CC2C2702; Mon, 2 Aug 2021 15:29:27 +0200 (CEST) From: Andreas Schwab To: "H.J. Lu via Libc-alpha" Subject: Re: [PATCH 2/2] ld.so: Hide _r_debug to support DT_DEBUG [BZ #28130] References: <20210802042940.932692-1-hjl.tools@gmail.com> <20210802042940.932692-2-hjl.tools@gmail.com> X-Yow: They collapsed.... like nuns in the street... they had no teen appeal! Date: Mon, 02 Aug 2021 15:29:27 +0200 In-Reply-To: <20210802042940.932692-2-hjl.tools@gmail.com> (H. J. Lu via Libc-alpha's message of "Sun, 1 Aug 2021 21:29:40 -0700") Message-ID: <87h7g8ug94.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Aug 01 2021, H.J. Lu via Libc-alpha wrote: > 1. Add a function, __r_debug_location, which returns the address of > _r_debug: > > /* Return the address of that structure used by the dynamic linker. */ > extern struct r_debug * __r_debug_location (void) __attribute_const__; > > It has a special glibc version, GLIBC_DEBUG. > > 2. Hide _r_debug in ld.so by defining _r_debug with __r_debug_location: > > #define _r_debug (*__r_debug_location ()) There is no need for that. Nobody should be using _r_debug. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."