From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3AED01F953 for ; Fri, 26 Nov 2021 20:28:28 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1B6033857C43 for ; Fri, 26 Nov 2021 20:28:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1B6033857C43 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637958506; bh=f37+OLIoFdVDoDeWpTIPJyfe4wycTuhGDhz6VGs7yIc=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=SZXw2xlqZO1zHgWgepc12U/YsSBI5Uw+oc4dugesIDUiP4okWs6etp7tXMe2eLt85 ALhmey/EHE4EhtKjGMVk8TE7iUUvJB4qI6tpAK3IGmUbBf7PvDM9hjMb3bTkSJLi8f kItQyDNnQHeJENEwbvydiquVbFQlc4uc+rvNCQqo= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C06803858D39 for ; Fri, 26 Nov 2021 20:28:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C06803858D39 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-464-t-jvv6PXOVi5ZO8gOZkTeQ-1; Fri, 26 Nov 2021 15:28:00 -0500 X-MC-Unique: t-jvv6PXOVi5ZO8gOZkTeQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3BEBA102CB29; Fri, 26 Nov 2021 20:27:59 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F50210016FE; Fri, 26 Nov 2021 20:27:57 +0000 (UTC) To: luca.boccassi@gmail.com Subject: Re: [PATCH v2] elf: add definition for NT_FDO_PACKAGING_METADATA note References: <20211121193939.105186-1-luca.boccassi@gmail.com> <20211126170127.1075409-1-luca.boccassi@gmail.com> Date: Fri, 26 Nov 2021 21:27:55 +0100 In-Reply-To: <20211126170127.1075409-1-luca.boccassi@gmail.com> (luca boccassi's message of "Fri, 26 Nov 2021 17:01:27 +0000") Message-ID: <87h7byirw4.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: mark@klomp.org, libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * luca boccassi: > From: Luca Boccassi > > As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/ > this note will be used starting from Fedora 36. > > Signed-off-by: Luca Boccassi > --- > v2: as suggested by Mark, indent comment and add NT_ suffix > > elf/elf.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/elf/elf.h b/elf/elf.h > index 50f87baceb..f2b72bd9f5 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -1302,6 +1302,10 @@ typedef struct > /* Program property. */ > #define NT_GNU_PROPERTY_TYPE_0 5 > > +/* Packaging metadata as defined on > + https://systemd.io/COREDUMP_PACKAGE_METADATA/ */ > +#define NT_FDO_PACKAGING_METADATA 0xcafe1a7e > + > /* Note section name of program property. */ > #define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property" Would you please add a definition of ELF_NOTE_FDO earlier in the file, similar to ELF_NOTE_GNU? I would like to point out that the format of the note is JSON-encoded, so it's not really how we have done things so far in the GNU ABI. I guess we can add this as a one-off exception. It shouldn't be an example where things are supposed to go in the future. Thanks, Florian