From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D07051F910 for ; Sun, 27 Nov 2022 18:22:18 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="QB4kFKGK"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 708D53858C5E for ; Sun, 27 Nov 2022 18:22:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 708D53858C5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669573337; bh=5Iw+UPNhCVZD+dFntoDtwn3gAtiN3+fQEkqEH/Zc4xE=; h=To:Cc:Subject:References:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=QB4kFKGKJrovLMOAljm5W+KUPjcMzcvtAFj5oMY2gfz3hzCqXPLQJW+RGLmLGaSpd rYYyat2Uj0sgvGrn2vXUVpj1rsbn3K3irHUwLRMERxqZkuKeTqNH2xmSNava2brp7V IZ8l0dmnteCHMQep3J6CG5ej6W3an44xOMgv7Km4= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9F3DA3858D3C for ; Sun, 27 Nov 2022 18:21:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9F3DA3858D3C Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-91-x1fpuE9BMdyWEV7kOtPQDQ-1; Sun, 27 Nov 2022 13:21:54 -0500 X-MC-Unique: x1fpuE9BMdyWEV7kOtPQDQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8033E101A52A; Sun, 27 Nov 2022 18:21:54 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B00740C2087; Sun, 27 Nov 2022 18:21:53 +0000 (UTC) To: Shahab Vahedi Cc: libc-alpha@sourceware.org, Claudiu Zissulescu , arcml Subject: Re: [PATCH v3 1/2] scripts: Add "|" operator support to glibcpp's parsing References: <20221118131542.23188-1-shahab@synopsys.com> <20221127173825.3106-1-shahab@synopsys.com> <20221127173825.3106-2-shahab@synopsys.com> Date: Sun, 27 Nov 2022 19:21:49 +0100 In-Reply-To: <20221127173825.3106-2-shahab@synopsys.com> (Shahab Vahedi's message of "Sun, 27 Nov 2022 18:38:24 +0100") Message-ID: <87h6yk1cn6.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Shahab Vahedi: > From the tests point of view, this is a necessary step for another > patch [1] and allows parsing macros such as "#define A | B". Without > it, a few tests [2] choke when the other patch [1] is applied: > > /src/glibc/scripts/../elf/elf.h:4167: error: uninterpretable macro > token sequence: ( EF_ARC_MACH_MSK | EF_ARC_OSABI_MSK ) > Traceback (most recent call last): > File "/src/glibc/elf/tst-glibcelf.py", line 23, in > import glibcelf > File "/src/glibc/scripts/glibcelf.py", line 226, in > _elf_h = _parse_elf_h() > ^^^^^^^^^^^^^^ > File "/src/glibc/scripts/glibcelf.py", line 223, in _parse_elf_h > raise IOError('parse error in elf.h') > OSError: parse error in elf.h > > [1] ARC: update definitions in elf/elf.h > https://sourceware.org/pipermail/libc-alpha/2022-November/143503.html > > [2] > tst-glibcelf, tst-relro-ldso, and tst-relro-libc > > Signed-off-by: Shahab Vahedi This okay and can go in separately, thanks. Reviewed-by: Florian Weimer Florian