unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: 'GNU C Library' <libc-alpha@sourceware.org>
Subject: Re: [PATCH] malloc: Use correct C11 atomics for fastbin
Date: Mon, 21 Nov 2022 17:18:40 +0100	[thread overview]
Message-ID: <87fsecth5r.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <PAWPR08MB8982002BD1E5CE0E74F4F19B830A9@PAWPR08MB8982.eurprd08.prod.outlook.com> (Wilco Dijkstra's message of "Mon, 21 Nov 2022 16:09:05 +0000")

* Wilco Dijkstra:

> Fix memory ordering issues in the fastbin implementation: in REMOVE_FB the
> next pointer is read before any MO synchronization, however in the C11 atomic
> model this is only correct after a load acquire. Refactor the fastbin code
> and add a dedicated fastbin_push/pop implementation. The number of acquire
> or release atomics remains the same, and the new functions are inlined, so
> performance is unaffected.
>
> Passes regress, OK for commit?

Did you actually observe any problems resulting from this?  We
previously concluded that the dependency chain would mae this valid
(outside the C11 memory model).

Thanks,
Florian


  reply	other threads:[~2022-11-21 16:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 16:09 [PATCH] malloc: Use correct C11 atomics for fastbin Wilco Dijkstra via Libc-alpha
2022-11-21 16:18 ` Florian Weimer via Libc-alpha [this message]
2022-11-21 16:55   ` Wilco Dijkstra via Libc-alpha
2022-11-21 16:56     ` Wilco Dijkstra via Libc-alpha
2022-11-21 17:00     ` Florian Weimer via Libc-alpha
2022-12-02  5:11 ` DJ Delorie via Libc-alpha
2022-12-02  6:36   ` Florian Weimer via Libc-alpha
2022-12-02 10:56     ` Wilco Dijkstra via Libc-alpha
2022-12-02 11:24       ` Florian Weimer via Libc-alpha
2022-12-02 12:02         ` Wilco Dijkstra via Libc-alpha
2022-12-02 18:55           ` DJ Delorie via Libc-alpha
2022-12-05 18:39             ` Zack Weinberg via Libc-alpha
2022-12-06 16:19               ` DJ Delorie via Libc-alpha
2022-12-12  3:35                 ` Zack Weinberg via Libc-alpha
2022-12-12 11:57                   ` Florian Weimer via Libc-alpha
2022-12-12 11:56                 ` Florian Weimer via Libc-alpha
2022-12-06 13:29             ` Wilco Dijkstra via Libc-alpha
2022-12-06 13:37               ` Adhemerval Zanella Netto via Libc-alpha
2022-12-06 14:31                 ` Zack Weinberg via Libc-alpha
2022-12-06 16:23               ` DJ Delorie via Libc-alpha
2022-12-15 15:43                 ` Wilco Dijkstra via Libc-alpha
2022-12-02 18:55     ` DJ Delorie via Libc-alpha
  -- strict thread matches above, loose matches on Subject: below --
2022-12-06 15:04 Wilco Dijkstra via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsecth5r.fsf@oldenburg.str.redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=fweimer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).