From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5285F1F461 for ; Mon, 2 Sep 2019 14:28:24 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=tjKFI E3j/dO3PdJjN92qdsHFDyRKbv4IYOSftfkrbf9pY74U1A5crWjDCOxPgcYCIAB9/ nFC7GWtptSD6r6rrivGRb4ylTb1KdMItYkhMSg9Ev+KN2ur/QTxSGDvRDTFEeHRx 5yTYWo1v+vE767RCNMVdkTkkT6vxRgMCeQaSN4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=7fgihU2HitI F8R326tMdKWba2ts=; b=GCwffKsoDjGllhknWbosXivtSnNimyK07ePGOh4nXCj lk6V8apT02KvmMovTSKskamUw/S11ax8re0Mm8RcQOgjfXLgauDPHccVTtacWNEl KzYu/lWiJXyzh2ejzgIzqU7XV8hIXnBBIeSBpScYVpqdIXoVQfpJ/KsEGgN/PGUE = Received: (qmail 21891 invoked by alias); 2 Sep 2019 14:28:22 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 21883 invoked by uid 89); 2 Sep 2019 14:28:21 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: "Gabriel F. T. Gomes" Cc: Subject: Re: [PATCH 1/6] ldbl-128ibm-compat: Add regular character printing functions References: <20190809183154.32605-1-gabriel@inconstante.net.br> <20190809183154.32605-2-gabriel@inconstante.net.br> <87wofgdl5s.fsf@oldenburg2.str.redhat.com> <20190815153021.40983ca5@tereshkova> <20190902110321.48d0a1b2@tereshkova> Date: Mon, 02 Sep 2019 16:28:16 +0200 In-Reply-To: <20190902110321.48d0a1b2@tereshkova> (Gabriel F. T. Gomes's message of "Mon, 2 Sep 2019 11:03:21 -0300") Message-ID: <87ef0yvklb.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain * Gabriel F. T. Gomes: > On Thu, 15 Aug 2019, Gabriel F. T. Gomes wrote: > >>On Wed, 14 Aug 2019, Florian Weimer wrote: >> >>>Why isn't the assignment to obj-suf-foreach dead? >> >>Oh! There's a hunk missing in this patch. It should have the following >>extra statement: >> >>+$(call obj-suf-foreach,$(ldbl-ibm128-files)): \ >>+ sysdep-CFLAGS += -mabi=ibmlongdouble >> >>I accidentally removed it when preparing the patch for submission. Sorry >>and thanks for catching it. >> >>It does not affect the test results because there's nothing currently >>adding -mabi=ieeelongdouble to the build of powerpc64le files. Anyway, >>I'll reinstate this hunk locally, because it makes it clear *and explicit* >>that these files must be built with -mabi=ibmlongdouble, regardless of >>what becomes the default (if the default changes). > > Are you OK with this explanation (and amendment)? I like the idea of > making it explicit that -mabi=ibmlongdouble is required for these files. Sure, but it's not clear to me what the current state of the entire series. Is there a branch on sourceware with the updated set of patches? Thanks, Florian