From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: libc-alpha <libc-alpha@sourceware.org>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH glibc 0/3] Restartable Sequences enablement
Date: Mon, 25 May 2020 16:28:49 +0200 [thread overview]
Message-ID: <87eer8w0ke.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <250952375.33263.1590414739268.JavaMail.zimbra@efficios.com> (Mathieu Desnoyers's message of "Mon, 25 May 2020 09:52:19 -0400 (EDT)")
* Mathieu Desnoyers:
> ----- On May 20, 2020, at 7:44 AM, Florian Weimer fweimer@redhat.com wrote:
>
>> * Mathieu Desnoyers via Libc-alpha:
>>
>>> Florian, if you find the patches OK and possibly with a bit of
>>> tweaking of the commit messages, can you please commit them
>>> to glibc ?
>>
>> I had some final review comments, and I found a real bug: the uptr
>> changes in <sys/rseq.h> are problematic.
>
> Hi Florian,
>
> Can you share what issue you have found with the uptr changes ?
I thought I had written about something here:
<https://sourceware.org/pipermail/libc-alpha/2020-May/114142.html>
But it's not very explicit. I must have deleted it before sending it.
The problem is that you made substantial changes to the fallback
definitions compared to the kernel version. But those will never be
used if the user has the appropriate kernel headers installed. The
fallback part really has to be an almost-verbatim copy of the kernel
definitions.
Thanks,
Florian
next prev parent reply other threads:[~2020-05-25 14:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 2:14 [PATCH glibc 0/3] Restartable Sequences enablement Mathieu Desnoyers via Libc-alpha
2020-05-01 2:14 ` [PATCH glibc 1/3] glibc: Perform rseq registration at C startup and thread creation (v19) Mathieu Desnoyers via Libc-alpha
2020-05-20 11:40 ` Florian Weimer via Libc-alpha
2020-05-25 14:51 ` Mathieu Desnoyers via Libc-alpha
2020-05-25 15:20 ` Florian Weimer via Libc-alpha
2020-05-25 17:36 ` Mathieu Desnoyers via Libc-alpha
2020-05-26 12:41 ` Florian Weimer via Libc-alpha
2020-05-26 14:32 ` Mathieu Desnoyers via Libc-alpha
2020-05-26 14:38 ` Florian Weimer via Libc-alpha
2020-05-26 14:53 ` Mathieu Desnoyers via Libc-alpha
2020-05-26 14:57 ` Florian Weimer via Libc-alpha
2020-05-26 15:22 ` Mathieu Desnoyers via Libc-alpha
2020-05-01 2:14 ` [PATCH glibc 2/3] glibc: sched_getcpu(): use rseq cpu_id TLS on Linux (v7) Mathieu Desnoyers via Libc-alpha
2020-05-20 10:14 ` Florian Weimer via Libc-alpha
2020-05-01 2:14 ` [PATCH glibc 3/3] rseq registration tests (v10) Mathieu Desnoyers via Libc-alpha
2020-05-20 10:52 ` Florian Weimer via Libc-alpha
2020-05-25 17:07 ` Mathieu Desnoyers via Libc-alpha
2020-05-26 12:47 ` Florian Weimer via Libc-alpha
2020-05-26 14:43 ` Mathieu Desnoyers via Libc-alpha
2020-05-27 15:05 ` Mathieu Desnoyers via Libc-alpha
2020-05-27 15:12 ` Florian Weimer via Libc-alpha
2020-05-27 15:17 ` Mathieu Desnoyers via Libc-alpha
2020-05-27 15:21 ` Florian Weimer via Libc-alpha
2020-05-27 15:30 ` Mathieu Desnoyers via Libc-alpha
2020-05-20 11:44 ` [PATCH glibc 0/3] Restartable Sequences enablement Florian Weimer via Libc-alpha
2020-05-25 13:52 ` Mathieu Desnoyers via Libc-alpha
2020-05-25 14:28 ` Florian Weimer via Libc-alpha [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-27 18:51 Mathieu Desnoyers via Libc-alpha
2020-06-03 12:07 ` Florian Weimer via Libc-alpha
2020-06-03 12:27 ` Mathieu Desnoyers via Libc-alpha
2020-06-03 12:33 ` Florian Weimer via Libc-alpha
2020-06-03 13:40 ` Florian Weimer via Libc-alpha
2020-06-05 17:04 ` Mathieu Desnoyers via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eer8w0ke.fsf@oldenburg2.str.redhat.com \
--to=libc-alpha@sourceware.org \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).