From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 53BD11F5AE for ; Wed, 29 Jul 2020 16:25:59 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1F1C1384240B; Wed, 29 Jul 2020 16:25:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F1C1384240B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1596039958; bh=RYblfvwLnnRXk+Be1OxJyYwfOO0JxdVlmx+78clrrtU=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vJqXDTbjpIgJ8KZIDRmxTFTT0VrGSkrFoYUB1LHAVVZ3Km6I4VA00haHfonHw7Q5p F+xqd+7f3++rvGRjomw/qgSMyhemMCGFdG7oIcc+/7PlSS+OoA3m8FMOkDZIf/R4+u V+VIRLMCqZEC0HstGYu6THGAZkQO+4jNdlGEFZWM= Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 03468385EC54 for ; Wed, 29 Jul 2020 16:25:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 03468385EC54 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-87-E_lZovOxO9aDDw6iAOHnyw-1; Wed, 29 Jul 2020 12:25:48 -0400 X-MC-Unique: E_lZovOxO9aDDw6iAOHnyw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EFA2F1893DC6; Wed, 29 Jul 2020 16:25:46 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-29.ams2.redhat.com [10.36.113.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC2E319D82; Wed, 29 Jul 2020 16:25:45 +0000 (UTC) To: Alan Modra via Libc-alpha Subject: Re: Emit a warning when -z relro is unsupported References: <20200619024818.GA21885@bubble.grove.modra.org> <20200729003850.GO9601@bubble.grove.modra.org> <20200729071002.GP9601@bubble.grove.modra.org> Date: Wed, 29 Jul 2020 18:25:44 +0200 In-Reply-To: <20200729071002.GP9601@bubble.grove.modra.org> (Alan Modra via Libc-alpha's message of "Wed, 29 Jul 2020 16:40:02 +0930") Message-ID: <87eeounv93.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: binutils@sourceware.org, Joseph Myers , Alan Modra Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" * Alan Modra via Libc-alpha: > From 3425515f19d47eb2e13180fe031d94a9c13ce39b Mon Sep 17 00:00:00 2001 > From: Alan Modra > Date: Wed, 29 Jul 2020 16:28:57 +0930 > Subject: Don't mix linker error messages into edited scripts > > * Makerules (shlib.lds): Discard linker warning output. > (format.lds): Likewise. > > diff --git a/Makerules b/Makerules > index 341db86c7e..ef0fe67d9a 100644 > --- a/Makerules > +++ b/Makerules > @@ -557,7 +557,7 @@ $(common-objpfx)shlib.lds: $(common-objpfx)config.make $(..)Makerules > $(LINK.o) -shared -Wl,-O1 \ > -nostdlib -nostartfiles \ > $(sysdep-LDFLAGS) $(rtld-LDFLAGS) $(LDFLAGS.so) \ > - -Wl,--verbose 2>&1 | \ > + -Wl,--verbose 2>/dev/null | \ > sed > $@T \ > -e '/^=========/,/^=========/!d;/^=========/d' \ > $(if $(filter yes,$(have-hash-style)), \ > @@ -1073,7 +1073,7 @@ ifneq (unknown,$(output-format)) > else > $(LINK.o) -shared $(sysdep-LDFLAGS) $(rtld-LDFLAGS) \ > $(LDFLAGS.so) $(LDFLAGS-lib.so) \ > - -x c /dev/null -o $@.so -Wl,--verbose -v 2>&1 \ > + -x c /dev/null -o $@.so -Wl,--verbose -v 2>/dev/null \ > | sed -n -f $< > $@.new > test -s $@.new > rm -f $@.so This change looks reasonable to me. Thanks for tracking this down. We are in the glibc 2.32, so Carlos as the release manager needs to approve this. Florian