From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A2CAD1F8C6 for ; Wed, 28 Jul 2021 08:18:09 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D13BA398CC24 for ; Wed, 28 Jul 2021 08:18:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D13BA398CC24 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627460288; bh=ErcDM6GNIcX4FFySZ2fF3Ke4sDisY/OvrnB4tRY9P/o=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=palPz1nTEbOx/Pl0/nP8Mm0uZG+Iwma1wEGv7fsQCNH9Yp51FxSW5B2Fu0qQ5RwQe Em9PuDhAziQFVAc/J56nxhnSxyIhXIBOsMpiWQnGOW/EYkePjGgB59uPfGqxtkpurz bPu778qxHAQ8QLk8FTNtifLCtTdF2dfbzlFMdMZ8= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 4407F3988421 for ; Wed, 28 Jul 2021 07:31:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4407F3988421 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-20-T8xe7K6ONo6nsYyivFuWjg-1; Wed, 28 Jul 2021 03:31:35 -0400 X-MC-Unique: T8xe7K6ONo6nsYyivFuWjg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 035DF10C1972; Wed, 28 Jul 2021 07:31:26 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-7.ams2.redhat.com [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2679860C05; Wed, 28 Jul 2021 07:31:24 +0000 (UTC) To: Siddhesh Poyarekar Subject: Re: [PATCH v2] __cxa_thread_atexit_impl: Abort on allocation failure [BZ #18524] References: <20210728072854.3915796-1-siddhesh@sourceware.org> Date: Wed, 28 Jul 2021 09:31:23 +0200 In-Reply-To: <20210728072854.3915796-1-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Wed, 28 Jul 2021 12:58:54 +0530") Message-ID: <87eebiao8k.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Siddhesh Poyarekar: > @@ -104,6 +105,8 @@ __cxa_thread_atexit_impl (dtor_func func, void *obj, void *dso_symbol) > > /* Prepend. */ > struct dtor_list *new = calloc (1, sizeof (struct dtor_list)); > + if (__glibc_unlikely (new == NULL)) > + __libc_fatal ("failed to register TLS destructor: out of memory"); > new->func = func; > new->obj = obj; > new->next = tls_dtor_list; Please add "Fatal glibc error: " and "\n". Thanks, Florian