unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / code / Atom feed
* [PATCH v2] __cxa_thread_atexit_impl: Abort on allocation failure [BZ #18524]
@ 2021-07-28  7:28 Siddhesh Poyarekar via Libc-alpha
  2021-07-28  7:31 ` Florian Weimer via Libc-alpha
  0 siblings, 1 reply; 2+ messages in thread
From: Siddhesh Poyarekar via Libc-alpha @ 2021-07-28  7:28 UTC (permalink / raw)
  To: libc-alpha; +Cc: fweimer

Abort in the unlikely event that allocation fails when trying to
register a TLS destructor.
---
 stdlib/cxa_thread_atexit_impl.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/stdlib/cxa_thread_atexit_impl.c b/stdlib/cxa_thread_atexit_impl.c
index 577ed30931..d789f043f2 100644
--- a/stdlib/cxa_thread_atexit_impl.c
+++ b/stdlib/cxa_thread_atexit_impl.c
@@ -72,6 +72,7 @@
    is not very different from a case where __call_tls_dtors is called after
    _dl_close_worker on the DSO and hence is an accepted execution.  */
 
+#include <stdio.h>
 #include <stdlib.h>
 #include <ldsodefs.h>
 
@@ -104,6 +105,8 @@ __cxa_thread_atexit_impl (dtor_func func, void *obj, void *dso_symbol)
 
   /* Prepend.  */
   struct dtor_list *new = calloc (1, sizeof (struct dtor_list));
+  if (__glibc_unlikely (new == NULL))
+    __libc_fatal ("failed to register TLS destructor: out of memory");
   new->func = func;
   new->obj = obj;
   new->next = tls_dtor_list;
-- 
2.31.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] __cxa_thread_atexit_impl: Abort on allocation failure [BZ #18524]
  2021-07-28  7:28 [PATCH v2] __cxa_thread_atexit_impl: Abort on allocation failure [BZ #18524] Siddhesh Poyarekar via Libc-alpha
@ 2021-07-28  7:31 ` Florian Weimer via Libc-alpha
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer via Libc-alpha @ 2021-07-28  7:31 UTC (permalink / raw)
  To: Siddhesh Poyarekar; +Cc: libc-alpha

* Siddhesh Poyarekar:

> @@ -104,6 +105,8 @@ __cxa_thread_atexit_impl (dtor_func func, void *obj, void *dso_symbol)
>  
>    /* Prepend.  */
>    struct dtor_list *new = calloc (1, sizeof (struct dtor_list));
> +  if (__glibc_unlikely (new == NULL))
> +    __libc_fatal ("failed to register TLS destructor: out of memory");
>    new->func = func;
>    new->obj = obj;
>    new->next = tls_dtor_list;

Please add "Fatal glibc error: " and "\n".

Thanks,
Florian


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-28  8:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28  7:28 [PATCH v2] __cxa_thread_atexit_impl: Abort on allocation failure [BZ #18524] Siddhesh Poyarekar via Libc-alpha
2021-07-28  7:31 ` Florian Weimer via Libc-alpha

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/glibc.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).