unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2] __cxa_thread_atexit_impl: Abort on allocation failure [BZ #18524]
Date: Wed, 28 Jul 2021 09:31:23 +0200	[thread overview]
Message-ID: <87eebiao8k.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210728072854.3915796-1-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Wed, 28 Jul 2021 12:58:54 +0530")

* Siddhesh Poyarekar:

> @@ -104,6 +105,8 @@ __cxa_thread_atexit_impl (dtor_func func, void *obj, void *dso_symbol)
>  
>    /* Prepend.  */
>    struct dtor_list *new = calloc (1, sizeof (struct dtor_list));
> +  if (__glibc_unlikely (new == NULL))
> +    __libc_fatal ("failed to register TLS destructor: out of memory");
>    new->func = func;
>    new->obj = obj;
>    new->next = tls_dtor_list;

Please add "Fatal glibc error: " and "\n".

Thanks,
Florian


      reply	other threads:[~2021-07-28  8:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28  7:28 [PATCH v2] __cxa_thread_atexit_impl: Abort on allocation failure [BZ #18524] Siddhesh Poyarekar via Libc-alpha
2021-07-28  7:31 ` Florian Weimer via Libc-alpha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eebiao8k.fsf@oldenburg.str.redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=fweimer@redhat.com \
    --cc=siddhesh@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).