From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6FE831F8C7 for ; Thu, 26 Aug 2021 14:43:42 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9408B3857C51 for ; Thu, 26 Aug 2021 14:43:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9408B3857C51 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629989021; bh=y7f4E1H1gnUYztV4z9GfQwtjkV47Q7+WP6f1AisNS2w=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=gvc9TPM8k4bkDXb7qH5imnVt+HX1SCF92ePhI12HLsJNEZLLQlQDs8RtA6mncOmHi sB3O9Vl9JLfqm6hQMp4CpQp9hAA+46ehzhgLqvJuvDyeZbVINkZKGyoMz683UjyRm5 Q0b4LqrLlmpLnReVMcuQFllPvmlhC9ddNuDsUMbI= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 1EADA3858402 for ; Thu, 26 Aug 2021 14:43:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1EADA3858402 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-vSpbd3inPaWCjssSzSUyOw-1; Thu, 26 Aug 2021 10:43:20 -0400 X-MC-Unique: vSpbd3inPaWCjssSzSUyOw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 74B06802937; Thu, 26 Aug 2021 14:43:19 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.140]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F7395D9FC; Thu, 26 Aug 2021 14:43:18 +0000 (UTC) To: Adhemerval Zanella Subject: Re: [PATCH v2 17/19] nptl: Use tidlock when accessing TID on pthread_sigqueue References: <20210823195047.543237-1-adhemerval.zanella@linaro.org> <20210823195047.543237-18-adhemerval.zanella@linaro.org> Date: Thu, 26 Aug 2021 16:43:16 +0200 In-Reply-To: <20210823195047.543237-18-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 23 Aug 2021 16:50:45 -0300") Message-ID: <87eeag5ksb.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Adhemerval Zanella: > + /* Block all signal, since the lock is recursive and used on pthread_cancel > + (which should be async-signal-safe). */ > + sigset_t oldmask; > + __libc_signal_block_all (&oldmask); > + lll_lock (pd->tidlock, LLL_PRIVATE); > + > + int res; > + if (pd->tid == 0) > + { > + pid_t pid = getpid (); Huh, that can't be right, should be pd->tid != 0. Don't we have test coverage for this? > + else > + res = -ESRCH; We can return 0 in this case, I think. It's possibly that the same issue regarding synchronous signal delivery for pthread_jill applies here. Thanks, Florian