Re: [PATCH v10 2/2] Add generic C.UTF-8 locale (Bug 17318)

[Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>]

* Carlos O'Donell:

> +* Support for the C.UTF-8 locale has been added to glibc.  The locale
> +  supports full code-point sorting for all valid Unicode code points.  A
> +  limitation in the framework for fnmatch, regexec, and regcomp requires
> +  a compromise to save space and only ASCII-based range expressions are
> +  supported for now (see bug 28255).  The full size of the locale is
> +  only ~400KiB, with 346KiB coming from LC_CTYPE information for
> +  Unicode. This locale harmonizes downstream C.UTF-8 already shipping in
> +  various downstream distributions.  The locale is not built into glibc,
> +  and must be installed.

Missing space after “Unicode.” (two spaces expected).

> diff --git a/posix/tst-regex.c b/posix/tst-regex.c
> index e7c2b05e86..4be5d173eb 100644
> --- a/posix/tst-regex.c
> +++ b/posix/tst-regex.c
> @@ -150,9 +151,23 @@ test_expr (const char *expr, int expected, int expectedicase)
>    size_t outlen;
>    char *uexpr;
>  
> -  /* First test: search with an UTF-8 locale.  */
> -  if (setlocale (LC_ALL, "de_DE.UTF-8") == NULL)
> -    error (EXIT_FAILURE, 0, "cannot set locale de_DE.UTF-8");
> +  /* First test: search with basic C.UTF-8 locale.  */
> +  printf ("INFO: Testing C.UTF-8.\n");
> +  xsetlocale (LC_ALL, "C.UTF-8");
> +
> +  printf ("\nTest \"%s\" with multi-byte locale\n", expr);
> +  result = run_test (expr, mem, memlen, 0, expected);
> +  printf ("\nTest \"%s\" with multi-byte locale, case insensitive\n", expr);
> +  result |= run_test (expr, mem, memlen, 1, expectedicase);
> +  printf ("\nTest \"%s\" backwards with multi-byte locale\n", expr);
> +  result |= run_test_backwards (expr, mem, memlen, 0, expected);
> +  printf ("\nTest \"%s\" backwards with multi-byte locale, case insensitive\n",
> +	  expr);
> +  result |= run_test_backwards (expr, mem, memlen, 1, expectedicase);
> +
> +  /* Second test: search with an UTF-8 locale.  */
> +  printf ("INFO: Testing de_DE.UTF-8.\n");
> +  xsetlocale (LC_ALL, "de_DE.UTF-8");
>  
>    printf ("\nTest \"%s\" with multi-byte locale\n", expr);
>    result = run_test (expr, mem, memlen, 0, expected);

This is another (or the same?) overwrite of the result variable.

Thanks,
Florian