From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 280F11F8C6 for ; Wed, 15 Sep 2021 10:41:26 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 82D0A3857C71 for ; Wed, 15 Sep 2021 10:41:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 82D0A3857C71 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631702484; bh=JF8/0qK0L6DzBKPA/6YZKESqcWZnyv2Z0KDGtZ6D9N8=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=jMziuKujWcuuRTpshPbddxpHBo0+FXwdM2GvqS82mQm4NUrK3n4Pp9xRDE6yT17HC zDHJhdfaZZ+xQlgZYolTlwPP3ZC6tI0QLPMuKXuZ5Q6CaN/QaP3eMbhMsMVKCG3Ix7 oztTgJnm0IFhQjgJrPfHPy5RCcwGg/GT8VHjQb8M= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 09C3A3858407 for ; Wed, 15 Sep 2021 10:41:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 09C3A3858407 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-154-QIru1upwMWiagrTC60qLBw-1; Wed, 15 Sep 2021 06:41:01 -0400 X-MC-Unique: QIru1upwMWiagrTC60qLBw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8DCEB1084685; Wed, 15 Sep 2021 10:41:00 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.194]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 80F84196E6; Wed, 15 Sep 2021 10:40:55 +0000 (UTC) To: Siddhesh Poyarekar Subject: Re: [PATCH v2] ld.so: Handle read-only dynamic section gracefully [BZ #28340] References: <20210915013653.1802776-1-siddhesh@sourceware.org> Date: Wed, 15 Sep 2021 12:40:53 +0200 In-Reply-To: <20210915013653.1802776-1-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Wed, 15 Sep 2021 07:06:53 +0530") Message-ID: <87ee9qt93e.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Siddhesh Poyarekar: > @@ -1149,6 +1152,9 @@ _dl_map_object_from_fd (const char *name, const char *origname, int fd, > such a segment to avoid a crash later. */ > l->l_ld = (void *) ph->p_vaddr; > l->l_ldnum = ph->p_memsz / sizeof (ElfW(Dyn)); > +#ifndef DL_RO_DYN_SECTION > + readonly_dynamic = (ph->p_flags & PF_W) == 0; > +#endif > } > break; As far as I can tell, this does not check whether the DYNAMIC segment is actually covered by a read-write LOAD segment. I wonder how much value this imperfect check has. Would it make more sense to fix the kernel linker script that generates those bogus vDSO reference files? Thanks, Florian