From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5C13C20248 for ; Mon, 15 Apr 2019 21:32:44 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:cc:subject:in-reply-to:references :date:message-id:mime-version:content-type; q=dns; s=default; b= yFBxmwFxwvwlLUVFmkb5+PVmtZipMiGCIBeEJ9wYrMhdglega8n/RpDU9ospTP2d 3q67xba1BYMUDL/gCjmTQyrC7GqsxK8mUtfBhnZQuaL7GEGRMfcptj3+1HECHhD4 EYAEhXEj8wwBb5/j1G5gafrsy6WwCe82VW1w6KrgtaE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:cc:subject:in-reply-to:references :date:message-id:mime-version:content-type; s=default; bh=i0KjC1 xiZzZy6UslrL2jIbF8lXs=; b=t9MQ/Iz3hSVyjDRziqUI+Dk9viqknZAKCjNhid 6tSJ3hyDyJfmrl6dBa09p84em+T5x1DWnz/bHUGP8rjvCZrtjZIgTUKYp1VXzbh0 d9DhRd++cUPvpZeVZLGeL2Gnh8+VBB/XgYL4H3RRYTcyPp/wGXp4WL6lY4qP0/3A 3ercI= Received: (qmail 55517 invoked by alias); 15 Apr 2019 21:32:42 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 55506 invoked by uid 89); 15 Apr 2019 21:32:41 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: golden.birch.relay.mailchannels.net X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|tuliom@ascii.art.br X-MailChannels-Auth-Id: dreamhost X-Dime-Versed: 5f5da78a44336b80_1555363958475_538304195 X-MC-Loop-Signature: 1555363958475:1793303437 X-MC-Ingress-Time: 1555363958475 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=ascii.art.br; h=from:to:cc :cc:subject:in-reply-to:references:date:message-id:mime-version :content-type; s=ascii.art.br; bh=i0KjC1xiZzZy6UslrL2jIbF8lXs=; b= PN9CNf58n2+YbNwEMN6+Ctt2Roo0oAbMBc32AnoVLJFQE3nT3sYJXz1dHrIqi+vV DnssfTzKvwqACOTmmxw+A3yqVsyFfSloQKLtlQRbE8sIPd6yBMm3bETbayDOPDJv KcVPdvVa9tPlMUNCwXKO+NnA+jWFSrd+3U4MqWqnudc= X-DH-BACKEND: pdx1-sub0-mail-a51 From: Tulio Magno Quites Machado Filho To: "Gabriel F. T. Gomes" , Adhemerval Zanella Cc: Joseph Myers , libc-alpha@sourceware.org Cc: Subject: Re: [PATCH 01/28] powerpc: Use generic fabs{f} implementations In-Reply-To: <20190415202356.7cltpw3akrcxjv6e@tereshkova> References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-2-adhemerval.zanella@linaro.org> <20190415202356.7cltpw3akrcxjv6e@tereshkova> User-Agent: Notmuch/0.27 (http://notmuchmail.org) Emacs/25.3.1 (x86_64-redhat-linux-gnu) Date: Mon, 15 Apr 2019 18:32:31 -0300 Message-ID: <87d0ln2bv4.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrvdelgdduiedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufgjfhgffffkgggtsehttdertddtredtnecuhfhrohhmpefvuhhlihhoucforghgnhhoucfsuhhithgvshcuofgrtghhrgguohcuhfhilhhhohcuoehtuhhlihhomhesrghstghiihdrrghrthdrsghrqeenucfkphepudeluddrhedrkedvrddutdehnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopegrshgtihhirdgrrhhtrdgsrhdpihhnvghtpeduledurdehrdekvddruddthedprhgvthhurhhnqdhprghthhepvfhulhhiohcuofgrghhnohcusfhuihhtvghsucforggthhgrughoucfhihhlhhhouceothhulhhiohhmsegrshgtihhirdgrrhhtrdgsrheqpdhmrghilhhfrhhomhepthhulhhiohhmsegrshgtihhirdgrrhhtrdgsrhdpnhhrtghpthhtoheplhhisggtqdgrlhhphhgrsehsohhurhgtvgifrghrvgdrohhrghenucevlhhushhtvghrufhiiigvpedt "Gabriel F. T. Gomes" writes: > The code generated by these functions is as follows (on powerpc64le): > > Before the patch: > 000000000004dac0 : > 4dac0: 0e 00 4c 3c addis r2,r12,14 > 4dac4: 40 9b 42 38 addi r2,r2,-25792 > 4dac8: 10 0a 20 fc fabs f1,f1 > 4dacc: 20 00 80 4e blr > > After the patch: > 000000000004dac0 : > 4dac0: 10 0a 20 fc fabs f1,f1 > 4dac4: 20 00 80 4e blr This is showing that __fabs could have been using ENTRY_TOCLESS instead of ENTRY. ;-) -- Tulio Magno