From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 54D551F462 for ; Thu, 23 May 2019 13:59:53 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=CwLlN KUsjsKfIXUHDEyEO15YYXdA2R+xjjSej/oGbNmz0s4cOjsWUHi7QPLndzIB1TF7+ 43bW2VGDlSQ2WhK6qD5SBJckZxyIw4Y3rkONCtPCa4EjRy5ysUeM9eSeE1930MDU I0lEnI+28sY+G9hX7n/1uWE8uaawFdgceRao7s= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=esL7EsIcZl9 IiV7SiX8TAi9khTo=; b=yMC0EdMspUb7YLUahRcGH7gY7t0WLe0UAk6L2afZmYc ZSZesOfP75LqCMY86IewsWlNPJ1XLlYnS0sCgO3LaQrCR5nymAVvkJfSEYKJrYm4 XHMInHZMHazRobKYBH4oBIMtI/LDtnxJoYefLv3D6PQjOkCIXCR1hh25oGMPJTOU = Received: (qmail 113624 invoked by alias); 23 May 2019 13:59:51 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 113614 invoked by uid 89); 23 May 2019 13:59:51 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: DJ Delorie Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH References: Date: Thu, 23 May 2019 15:59:47 +0200 In-Reply-To: (DJ Delorie's message of "Tue, 21 May 2019 09:24:20 -0400") Message-ID: <87d0k9xodo.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain * DJ Delorie: > Florian Weimer writes: >> Sorry, I don't understand. Why would the user want to run distcc *in >> the container*? > > That was just an example of an environment variable that affects the > build. I don't know what environment variables affect the test cases. > Timeout-related? Without a review of *every* test that might be run in > a container, we won't know what environment variables are valid for the > user to specify. But right now, only new tests run in a container, so I think we should focus on what helps us to write such new tests, so that they run in an environment that is as realistic as possible. We do not have many environment dependencies in the test harness itself: support/support_test_main.c: char *envstr_timeoutfactor = getenv ("TIMEOUTFACTOR"); support/support_test_main.c: test_dir = getenv ("TMPDIR"); support/support_test_main.c: const char *envstr_direct = getenv ("TEST_DIRECT"); support/support_test_main.c: const char *coredumps = getenv ("TEST_COREDUMPS"); TIMEOUTFACTOR and TEST_COREDUMPS are relevant, I think, and should not be filtered out. But TMPDIR and TEST_DIRECT are unlikely to work because they specify paths which may not be relevant in the chroot. Thanks, Florian