From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 013FC1F4B4 for ; Fri, 9 Oct 2020 17:13:08 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1C88A3851C0D; Fri, 9 Oct 2020 17:13:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1C88A3851C0D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1602263587; bh=jMKpodiYWJF9tFSmrugCSolXBUX7EGKoKefAvwXn9+0=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=tgwaLailTSFfN1dCbhazgsJ62UlxyFwP8o48nw0NlvVdJ0iFqiCw7DZeYP4WRMpqU NVLb9kMDf1nxaLDMG0KB4e4Gjzh/w57Fh9CYqa4IOBUcGe7pWipJfrRCR/czKBa5No XnnyBvhBfOF6E8qPz6otF1L++gqb2lteFSdu4IFs= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 9DC6E385780E for ; Fri, 9 Oct 2020 17:13:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9DC6E385780E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-481-6ylsgBYCNnq3aTYaUA3X_w-1; Fri, 09 Oct 2020 13:13:02 -0400 X-MC-Unique: 6ylsgBYCNnq3aTYaUA3X_w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6FBC81074643; Fri, 9 Oct 2020 17:13:01 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-154.ams2.redhat.com [10.36.113.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB9525C1BB; Fri, 9 Oct 2020 17:13:00 +0000 (UTC) To: Florian Weimer via Libc-alpha Subject: Re: [PATCH 14/28] elf: Enhance ld.so --help to print HWCAP subdirectories References: <87h7r3ba39.fsf@oldenburg2.str.redhat.com> Date: Fri, 09 Oct 2020 19:12:59 +0200 In-Reply-To: <87h7r3ba39.fsf@oldenburg2.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Fri, 09 Oct 2020 19:08:58 +0200") Message-ID: <87d01rb9wk.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" * Florian Weimer via Libc-alpha: > * Matheus Castanho: > >> I could reproduce this on both ppc64le and x84_64 with >> --disable-tunables. Are we missing an `#include `? >> >> diff --git a/elf/dl-usage.c b/elf/dl-usage.c >> index c07f43835b..796ad38b43 100644 >> --- a/elf/dl-usage.c >> +++ b/elf/dl-usage.c >> @@ -22,6 +22,7 @@ >> #include >> #include "version.h" >> >> +#include >> #include > > Right, I think that's what's missing. It's an oversight on my part. I > tried build-many-glibcs.py on the whole series, but it doesn't have a > configuration without tunables. > > Would you please post your patch to the list? You can also push it at > the same time if you want, I think missing #includes are considered > trivial under the check-in policy. Eh, clearly you have posted this to the list already. It's been a long day. 8-/ Please check this in at your convenience. Thanks. Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill