From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id F06EA1F990 for ; Wed, 5 Aug 2020 15:39:53 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ED7FA3860C3D; Wed, 5 Aug 2020 15:39:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ED7FA3860C3D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1596641993; bh=LKwLcMf/abaFJZ4xYkwCzQdm2L2ZAfaDeJ3TFVKWoZM=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=m7zlC7DcO8rP05to0+lO5Izef3zf7X7sbR8aGl2LJ9M0FQWHglKYNBfhi6b1Cu4bU frhOKl5uf4NsFMcNA58l5i43j3bmVh4DcCsWZ2upZz/BugOcq22KYVTsvy6Y+9/5An gK24oL2pfbQ6RfmrdHrtpUiW6il0EN7NOgGPvVbc= Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 1AC7F3857008 for ; Wed, 5 Aug 2020 15:39:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1AC7F3857008 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-HDLLRz2xPq6J7XlXCHj45w-1; Wed, 05 Aug 2020 11:39:46 -0400 X-MC-Unique: HDLLRz2xPq6J7XlXCHj45w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5199757; Wed, 5 Aug 2020 15:39:45 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-189.ams2.redhat.com [10.36.112.189]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A3FDE5D9DC; Wed, 5 Aug 2020 15:39:44 +0000 (UTC) To: Stefan Liebler via Libc-alpha Subject: Re: [PATCH] build-many-glibcs.py: Add some s390x glibc variants. References: <20200805144511.3482867-1-stli@linux.ibm.com> Date: Wed, 05 Aug 2020 17:39:43 +0200 In-Reply-To: <20200805144511.3482867-1-stli@linux.ibm.com> (Stefan Liebler via Libc-alpha's message of "Wed, 5 Aug 2020 16:45:11 +0200") Message-ID: <87bljpumo0.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: Stefan Liebler Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" * Stefan Liebler via Libc-alpha: > There is a s390x configure check which checks the architecture level set. > > This ALS influences e.g. which ifunc variants are needed or which one is > the default variant or if the symbol will be an ifunc-symbol at all. > > The ALS also enables to use the gcc builtins for e.g. the round function > in libm and others. > > Therefore this patch adds some glibc variants which are using different > architecture level sets for s390x. Do these additional build targets actually result in build breakage? I'm not sure if anyone does run-time testing on build-many-glibcs.py output. I would rather suggest adding an -O3 targets (maybe s390x due to its inliner differences, and x86-64), where we know we have occasional build breakage. Thanks, Florian