From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-bounces@sourceware.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS,
	SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from sourceware.org (server2.sourceware.org [8.43.85.97])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id 8137C1F990
	for <e@80x24.org>; Wed,  5 Aug 2020 19:56:11 +0000 (UTC)
Received: from server2.sourceware.org (localhost [IPv6:::1])
	by sourceware.org (Postfix) with ESMTP id 682843858D37;
	Wed,  5 Aug 2020 19:56:10 +0000 (GMT)
Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21])
 by sourceware.org (Postfix) with ESMTPS id A959D3858D35
 for <libc-alpha@sourceware.org>; Wed,  5 Aug 2020 19:56:07 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A959D3858D35
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=deneb.enyo.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de
Received: from [172.17.203.2] (helo=deneb.enyo.de)
 by albireo.enyo.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 id 1k3PW9-0001Cb-7S; Wed, 05 Aug 2020 19:56:05 +0000
Received: from fw by deneb.enyo.de with local (Exim 4.92)
 (envelope-from <fw@deneb.enyo.de>)
 id 1k3PW9-0005eD-4B; Wed, 05 Aug 2020 21:56:05 +0200
From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 6/7] login: Use 64-bit time on struct lastlog
References: <20200805185915.2025314-1-adhemerval.zanella@linaro.org>
 <20200805185915.2025314-6-adhemerval.zanella@linaro.org>
Date: Wed, 05 Aug 2020 21:56:05 +0200
In-Reply-To: <20200805185915.2025314-6-adhemerval.zanella@linaro.org>
 (Adhemerval Zanella via Libc-alpha's message of "Wed, 5 Aug 2020
 15:59:14 -0300")
Message-ID: <87a6z8c1ey.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
Errors-To: libc-alpha-bounces@sourceware.org
Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org>

* Adhemerval Zanella via Libc-alpha:

> diff --git a/bits/types/struct_lastlog.h b/bits/types/struct_lastlog.h
> index 67ffec1b08..9e8983b57d 100644
> --- a/bits/types/struct_lastlog.h
> +++ b/bits/types/struct_lastlog.h
> @@ -24,11 +24,11 @@
>     previous logins.  */
>  struct lastlog
>  {
> -#if __WORDSIZE_TIME64_COMPAT32
> -  int32_t ll_time;
> +#if __WORDSIZE == 32
> +  int64_t ll_time;
>  #else
>    __time_t ll_time;
>  #endif

Should this check for __TIMESIZE instead of __WORDSIZE?  It shouldn't
make a difference; I just think it would be clearer.

Or maybe use int64_t unconditionally?  That would be simpler.