From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A88BF1F5AE for ; Sat, 17 Jul 2021 14:55:58 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 81AED383F431 for ; Sat, 17 Jul 2021 14:55:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 81AED383F431 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1626533757; bh=4fR3UBSw/g3fbqFEdovNfigq5Be25yvAmi+08ix6Whk=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Lf9LUzERNccGUzrMppB6QffEfHSBOHAClmZIdwBiWsDIh+6MdL1LDHT04e6rY92Hj JNJiqvjHMknnxp468CpgpvkqVsTevdQn4Gn+9Q26gy1yl4CNh0bsPTeKHPNxmfJt79 CHtu2odr0+W0BPC7rOCLefQFqVmy1804Zjb6eVw4= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id EC3563857815 for ; Sat, 17 Jul 2021 14:55:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EC3563857815 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-243-r65a1_0yOcSg8zMlCAMRlQ-1; Sat, 17 Jul 2021 10:55:31 -0400 X-MC-Unique: r65a1_0yOcSg8zMlCAMRlQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DCB72100B3AC; Sat, 17 Jul 2021 14:55:29 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-73.phx2.redhat.com [10.3.112.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9DB365C1D0; Sat, 17 Jul 2021 14:55:28 +0000 (UTC) To: Bruno Haible Subject: Re: Undefined use of weak symbols in gnulib References: <87o8e0p92r.fsf@oldenburg.str.redhat.com> <1680226.UWtE2gOZdF@omega> <87a6piluow.fsf@oldenburg.str.redhat.com> <1882380.6EOZElgKgl@omega> Date: Sat, 17 Jul 2021 16:55:26 +0200 In-Reply-To: <1882380.6EOZElgKgl@omega> (Bruno Haible's message of "Sat, 17 Jul 2021 16:38:55 +0200") Message-ID: <87a6mlyopt.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: bug-gnulib@gnu.org, libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Bruno Haible: > Florian Weimer wrote on 2021-04-28: >> However, you should really remove those weak symbol >> hacks. They won't have any effect for glibc 2.34 > > I'm trying to do this now. But what is the right condition? > > 1) I understand that it's only for glibc >= 2.34 on Linux (NPTL), > right? Not on Hurd (HTL)? Yes, Hurd hasn't been integrated. > 2) /usr/include/gnu/lib-names.h still defines LIBPTHREAD_SO. > How about not defining LIBPTHREAD_SO, since linking with it is supposed > to be a no-op in these newer glibc versions? I'm not sure if this is the right way, given that the file still exists for all currently supported targets. An alternative would be to add a macro to , such as PTHREAD_IN_LIBC. Thanks, Florian