From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D228A1FA04 for ; Wed, 3 Jun 2020 13:40:53 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 931733887006; Wed, 3 Jun 2020 13:40:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 931733887006 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1591191652; bh=aaGFw8FHaUNs2UXz3X1xEHZd0ynF1yoRqMfHGaOUWzE=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=IU8G35J38ORA2cKTxj2yKUqGxQwINiUAlok4cDmtBT03/BgWFlxc2hE+Tq239gcHP wobnR46TnsTvS2wiIJn7x0pPIomdiuOh+U/Nbj2LgAJlC0seP8dSITMYDCOHwHnmqH kfC/8CbnNkjlo4zZcROqN6ezlyYqOetDHxYbvOnk= Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 4A1D9383E824 for ; Wed, 3 Jun 2020 13:40:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4A1D9383E824 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-166-rJx0TRmmNzCVq58-OOehhQ-1; Wed, 03 Jun 2020 09:40:48 -0400 X-MC-Unique: rJx0TRmmNzCVq58-OOehhQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B756C64AE8; Wed, 3 Jun 2020 13:40:46 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-181.ams2.redhat.com [10.36.112.181]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BBE979323; Wed, 3 Jun 2020 13:40:45 +0000 (UTC) To: Florian Weimer via Libc-alpha Subject: Re: [PATCH glibc 0/3] Restartable Sequences enablement References: <20200527185130.5604-1-mathieu.desnoyers@efficios.com> <878sh4xshf.fsf@oldenburg2.str.redhat.com> Date: Wed, 03 Jun 2020 15:40:44 +0200 In-Reply-To: <878sh4xshf.fsf@oldenburg2.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Wed, 03 Jun 2020 14:07:40 +0200") Message-ID: <877dwow9lv.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: Mathieu Desnoyers , Joseph Myers Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" * Florian Weimer via Libc-alpha: > This series unfortunately needs to be rebased (with conflicts) on > current master. > > There is a new elf/tst-auditmany failure, showing bug 26076, but > actually caused by bug 26075 (I think). I will attempt to work around > these two issues, which are independent of the rseq changes. Mathieu, it turns out that a change like this is needed: diff --git a/elf/dl-tls.c b/elf/dl-tls.c index fa03234610..817bcbbf59 100644 --- a/elf/dl-tls.c +++ b/elf/dl-tls.c @@ -31,7 +31,7 @@ /* Amount of excess space to allocate in the static TLS area to allow dynamic loading of modules defining IE-model TLS data. */ -#define TLS_STATIC_SURPLUS 64 + DL_NNS * 100 +#define TLS_STATIC_SURPLUS 64 + DL_NNS * 176 /* Out-of-memory handler. */ I think you can just put that into the main rseq patch. This change needs to be mentioned in the commit message, of course. With this change, elf/tst-auditmany passes again for me. The increase (76 bytes) is larger than 32 bytes because we have not done this in quite a while. The cost in terms of additional TLS storage is quite significant, but it will also obscure some initial-exec-related dlopen failures. Conceptually, we could also switch to 64 + (DL_NNS - 1) * 176, an increase of 1040 bytes over what we have today. Thanks, Florian