From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4C1D91F44D for ; Mon, 25 Mar 2024 11:58:42 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i/aTw0hA; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 901E5385843A for ; Mon, 25 Mar 2024 11:58:41 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 13DDD3858C50 for ; Mon, 25 Mar 2024 11:58:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13DDD3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 13DDD3858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711367903; cv=none; b=oXko1xoqjkOKSVcwqm0vBI1Gf/2NHRSeLVdLOGIRKt1GRu3cEuenmX+wEZaZ+Vh0EmN0eVpSObsfIqp3BiEcu8PNUIJ5AwQBOH8SscES2LdOMo7tgHd7MpZH2YyB2wYb3wzK+IUvZNrks+iW8JR4SivTCHipvaLCK0u63w5SltU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711367903; c=relaxed/simple; bh=Ce8I//t2+DZiMlES7XJ6mG/kaxNl3l36zpPou4TtG7I=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=r5QLMx8cJ6zMw/tc2KWNnrkfzf8m3nAFj9pZfv9/++go/E7f+zMlIaQKHEtfWyI5US51wNfSzzOF0EI7zKLTaobPhI5nh4aE6n6OgOzbyh+Ly2Hd1swUuSbIErrD5V68g8IB6OAlqLmiPncrmVMQtcRzNli8ipdgeCb6cuNPdRE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711367901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+q1g0mj1vU1tIy+ef0TIRPunPWmRBqd2me/u0VPW82s=; b=i/aTw0hAQ/dSuK4y+LGHbffhG9CxQKvlX656KBVo19m8Bzur3zxQrzkzPQI613MYCzIlqj X00jGX5QbY3e4eRO0uZIXA/WCzxvEUcaP8PQ4GYp0BR5/zhNk7y9z5V+ODoHJw8iItOnjO sp9SYjnYJZj4ShsrcyjuinTalxTdqL4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-YvDNizK4PoCYam_61hoZSg-1; Mon, 25 Mar 2024 07:58:20 -0400 X-MC-Unique: YvDNizK4PoCYam_61hoZSg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 070A8101A56C; Mon, 25 Mar 2024 11:58:20 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.146]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0499C200B3BF; Mon, 25 Mar 2024 11:58:18 +0000 (UTC) From: Florian Weimer To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org, Samuel Thibault Subject: Re: [RFC PATCH 03/23] Allow glibc to be compiled without EXEC_PAGESIZE In-Reply-To: <87y1aon3vc.fsf@oldenburg.str.redhat.com> (Florian Weimer's message of "Mon, 11 Mar 2024 17:13:27 +0100") References: <20240103171502.1358371-1-bugaevc@gmail.com> <20240103171502.1358371-4-bugaevc@gmail.com> <87y1aon3vc.fsf@oldenburg.str.redhat.com> Date: Mon, 25 Mar 2024 12:58:13 +0100 Message-ID: <877chqa5gq.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org * Florian Weimer: > * Sergey Bugaev: > >> diff --git a/elf/dl-support.c b/elf/dl-support.c >> index 2f502c8b..6375dc95 100644 >> --- a/elf/dl-support.c >> +++ b/elf/dl-support.c >> @@ -135,7 +135,11 @@ void *_dl_random; >> #include >> #include >> >> -size_t _dl_pagesize = EXEC_PAGESIZE; >> +size_t _dl_pagesize >> +#ifdef EXEC_PAGESIZE >> + = EXEC_PAGESIZE >> +#endif >> +; > > I think the intent here is to initialize _dl_pagesize with a > conservative default, to avoid initialization ordering issues. > EXEC_PAGESIZE is supposed to be largest supported page size. This was committed without addressing the comment above. Thanks, Florian