From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D3C8F1F4C0 for ; Fri, 25 Oct 2019 17:00:53 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=ipPeX2pEkKyOQQkzXkPowDW5ZQSpqf6yO5uqh+ZJP7l e+aCmdEKGhDzRfqCG+ftnBv9LyYWWyKDljEz1F//cJTjeig7XTpPWkZq3l0nxq73 DRIQ6nkJoPLv5qj+sWtLBgHQXG4iTXi6T8TljPJ2dJdQgrTVes3zoBlYzJp8B8xM = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=p8SFq3GZgpptLA002UkVjiLTNSY=; b=xxHUCp3k15QIDAoCd p0uy6DJJELmBX8DHdmTiWqD9QMzRKNMhDATkzSkAXKUkQeIwTK4TRdQLeujaHdUN xDEEurCgPQifpGgjBCGk3r4hZd+r0UaeTgJDO3FcdSkvMZApJOTNszuYWh6F/MIZ a/y8X53bm3Pjfwjk13CKCkFeJU= Received: (qmail 66212 invoked by alias); 25 Oct 2019 17:00:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 66068 invoked by uid 89); 25 Oct 2019 17:00:36 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572022822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HgeG5cQSK/Aoyf4lp8qVjwr3WNY3+TcxAKNIHkTNY2k=; b=E9qXetaqa6OFE0lA91qq0V7rtwmq+Aa034PX9oiAabc68PBjLvasPoD43sTwM1FYSg0FZR ihpw4waIJpElsc15yuCKmtT+FwZmSs7EDbGctHkflim414eXlQxveuATpFxb6A4G0oIAcX +TYPIw+XX6EaEtKbPc4tiSDOCX+HUmk= From: Sergio Durigan Junior To: Joseph Myers Cc: Carlos O'Donell , libc-alpha Subject: Re: Setup non-pushing gerrit instance for glibc. References: <2e93ece9-386b-c587-9355-33a4695a3f02@redhat.com> Date: Fri, 25 Oct 2019 13:00:14 -0400 In-Reply-To: (Joseph Myers's message of "Fri, 25 Oct 2019 15:18:03 +0000") Message-ID: <875zkcpxpd.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable On Friday, October 25 2019, Joseph Myers wrote: > On Thu, 24 Oct 2019, Carlos O'Donell wrote: > >> * Try to setup email based code review in gerrit. >> - Currently email is outbound only. >> - We are looking at how to make it entirely email based, but tracked >> in gerrit. > > Right now gerrit is sending bounces for any email replies I send, despite= =20 > having set up a gerrit account to be able to reply, which=20 > suggests=20 > ought to suffice. Both before and after setting up an account it sent th= e=20 > same bounce: > > Gerrit Code Review was unable to parse your email. > > This might be because your email did not quote Gerrit's email, because= =20 > you are using an unsupported email client, or because of a bug. > > Thus, no actions were taken by Gerrit in response to this email, and yo= u=20 > should use the Gerrit website to continue. > > This email was sent in response to an email coming from this address. I= n=20 > case you did not send Gerrit an email, feel free to ignore this. > > This is a send-only email address. Replies to this message will not be= =20 > read or answered.-- > > Note: of course I didn't quote the junk from gerrit's email footer, I=20 > quoted only the relevant context I wanted to comment on. Gerrit needs to= =20 > identify what issue is being commented on either from References /=20 > In-Reply-To headers, or from e.g. an issue number in the subject line (I= =20 > think the latter is what Bugzilla uses, at least it doesn't expect=20 > anything in particular to be quoted from its outgoing messages). It ough= t=20 > to work with nothing quoted from the email being commented on, or with=20 > selected text being quoted and commented on (but I suppose it's also a=20 > good idea for it to have enough smarts to discard a full email quoted in = a=20 > top-post, I think Bugzilla automatically discards everything starting=20 > after a "-- " signature start line). Unfortunately, you do need to quote the content from the email footer. I agree that gerrit should be able to keep track of Message-Id's and match the replies using In-Reply-To, but unfortunately it doesn't do that. It relies on the information present at the quoted footer to determine which change the email refers to. I was also surprised by this when I was configuring the email support, because we had disabled the inclusion of the footer in all changes, and I started getting bounces as well. I had to re-enable the footer in order to get everything working. Thanks, --=20 Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/