From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 58FDF1F8C6 for ; Wed, 28 Jul 2021 08:27:43 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 93CAB3853C06 for ; Wed, 28 Jul 2021 08:27:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 93CAB3853C06 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627460862; bh=am45R1zg6oBCkbOVZDCUlFy3N6iVQ5ZGF0NoJfXGJpQ=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Qn/mOCI6fnOtBa0xlbN46YgRlxABQv4t7zbt1ti6gCynA84KHBXvp7HtbbfQb97Md 6/eysMRq70pupaB/TfXG2AT7vlex82CRSge133MP0ZXQJOP4vAznRcnYnJfLSXlJ4X fmQ8+d3omhnA2sRy7yvN5t0Bk5lBFmTWfw4Bm+gc= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 30FBC398B85E for ; Wed, 28 Jul 2021 07:58:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 30FBC398B85E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-WYDEt8ztMhm__WGQIHoH-w-1; Wed, 28 Jul 2021 03:58:33 -0400 X-MC-Unique: WYDEt8ztMhm__WGQIHoH-w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B563E1008060; Wed, 28 Jul 2021 07:58:32 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-7.ams2.redhat.com [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DCA847A8D4; Wed, 28 Jul 2021 07:58:31 +0000 (UTC) To: Siddhesh Poyarekar Subject: Re: [PATCH v2] tests: use xmalloc to allocate implementation array References: <20210728073530.3917457-1-siddhesh@sourceware.org> Date: Wed, 28 Jul 2021 09:58:30 +0200 In-Reply-To: <20210728073530.3917457-1-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Wed, 28 Jul 2021 13:05:30 +0530") Message-ID: <875ywuamzd.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Siddhesh Poyarekar: > The benchmark and tests must fail in case of allocation failure in the > implementation array. Also annotate the x* allocators in support.h so > that the compiler has more information about them. > --- > benchtests/bench-string.h | 5 +++-- > string/test-string.h | 5 +++-- > support/support.h | 24 +++++++++++++++++------- > 3 files changed, 23 insertions(+), 11 deletions(-) > > diff --git a/benchtests/bench-string.h b/benchtests/bench-string.h > index fd25264417..12f27473ff 100644 > --- a/benchtests/bench-string.h > +++ b/benchtests/bench-string.h > @@ -18,6 +18,7 @@ > > #include > #include > +#include > > /* We are compiled under _ISOMAC, so libc-symbols.h does not do this > for us. */ > @@ -200,8 +201,8 @@ static impl_t *impl_array; > skip = impl; \ > else \ > impl_count++; \ > - a = impl_array = malloc ((impl_count + func_count) * \ > - sizeof (impl_t)); \ > + a = impl_array = xmalloc ((impl_count + func_count) * \ > + sizeof (impl_t)); \ > for (impl = __start_impls; impl < __stop_impls; ++impl) \ > if (impl != skip) \ > *a++ = *impl; \ Okay if it actually links. Rest of the patch seems okay to me. Thanks, Florian