From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 97A801F8C6 for ; Thu, 26 Aug 2021 09:30:42 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2BCD23858435 for ; Thu, 26 Aug 2021 09:30:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2BCD23858435 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629970241; bh=AOhPi7MT2bLmnfadYMjQ6ZmNv7qQpdeyiWISluiBK1I=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TW40yWkx4jbsT/kgup/jQ4YzsOkKY7f1W8UZ/rpuUvgeFGS6ka8S5s7jxw+8mf/xm l2fVyVYRQ3wffnnZDoIU45mp6f5K0LLV0V37k5nt69Pa92G6Ny445vqvxCi5oKjhxA HVEvqJPa/HCFco/J/4KCrr4lEM3XglKJcLBKTgi8= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 224AB3858400 for ; Thu, 26 Aug 2021 09:30:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 224AB3858400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-BTYCFE1FNa2d8mZMvyemOw-1; Thu, 26 Aug 2021 05:30:18 -0400 X-MC-Unique: BTYCFE1FNa2d8mZMvyemOw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B809A1934103; Thu, 26 Aug 2021 09:30:17 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.140]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E1AF8604CC; Thu, 26 Aug 2021 09:30:16 +0000 (UTC) To: Adhemerval Zanella Subject: Re: [PATCH v2 19/19] nptl: Remove INVALID_TD_P References: <20210823195047.543237-1-adhemerval.zanella@linaro.org> <20210823195047.543237-20-adhemerval.zanella@linaro.org> Date: Thu, 26 Aug 2021 11:30:14 +0200 In-Reply-To: <20210823195047.543237-20-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 23 Aug 2021 16:50:47 -0300") Message-ID: <875yvsa6zd.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Adhemerval Zanella: > It is not used anymore. > --- > sysdeps/nptl/pthreadP.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/sysdeps/nptl/pthreadP.h b/sysdeps/nptl/pthreadP.h > index d366d691cd..67a9887da3 100644 > --- a/sysdeps/nptl/pthreadP.h > +++ b/sysdeps/nptl/pthreadP.h > @@ -239,11 +239,6 @@ libc_hidden_proto (__pthread_tpp_change_priority) > extern int __pthread_current_priority (void); > libc_hidden_proto (__pthread_current_priority) > > -/* This will not catch all invalid descriptors but is better than > - nothing. And if the test triggers the thread descriptor is > - guaranteed to be invalid. */ > -#define INVALID_TD_P(pd) __builtin_expect ((pd)->tid <= 0, 0) > - > extern void __pthread_unwind (__pthread_unwind_buf_t *__buf) > __cleanup_fct_attribute __attribute ((__noreturn__)) > #if !defined SHARED && !IS_IN (libpthread) Looks okay to me. Reviewed-by: Florian Weimer Thanks, Florian