From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3949A20248 for ; Thu, 28 Feb 2019 13:32:49 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=J9dr/ Rm1bCG4AkQAN71Xt2VX+/ct3m+Q1fweJCrtH6RPttRLkwBXye5j7EPjCn1Gb6SQw KiW9LxAAk7ysgbb3IKqnJt5TgI03vwq5nopWZ4YTqSr0EFOO0ujCAidJYovQDwrS DuFvIJkNeiWyAnA5znUbzTx4xf3mD9/UxkrYso= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=Vsr9GJlU+mA dz6vuw2X2+LgRMP4=; b=UjUYdekhZGXfgZidQSwkkdARPJVYg1LrCW/XMFHzytN OVyVHWUeWKs8HKF+Hrza/jAwa/Rg5MHKMNg1GyTL9bimDG59btVpPxQfOiV/4yeG qSGxSuBGqrARWQtnNe+x7nb/sv3D7ZdKoznegaPPKdsMWsHxkmsvPK+y9pVl0nGs = Received: (qmail 39586 invoked by alias); 28 Feb 2019 13:32:46 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 39574 invoked by uid 89); 28 Feb 2019 13:32:46 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: Zack Weinberg Cc: Martin =?utf-8?Q?Li=C5=A1ka?= , Joseph Myers , GNU C Library Subject: Re: [PATCH] Fix location where math-vector-fortran.h is installed. References: <863ffa3b-af66-7d82-21a8-e809fd6c1b62@suse.cz> <08214004-67b7-ce24-07ec-3cd685c65038@suse.cz> <84b2b212-a70a-e18a-5929-d89d6014fb70@suse.cz> <44cd0edb-2ab3-2908-8adb-f2e06859ecfe@suse.cz> <57bb8e48-8805-91ca-9902-9c6fbc3d5360@suse.cz> <87imx62qtr.fsf@oldenburg2.str.redhat.com> <974399a2-cf1a-1b23-bb9d-b97772278335@suse.cz> Date: Thu, 28 Feb 2019 14:32:40 +0100 In-Reply-To: (Zack Weinberg's message of "Thu, 28 Feb 2019 08:30:54 -0500") Message-ID: <874l8oqbrb.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain * Zack Weinberg: > Revised patch looks good to me except: > >> -! Platform-specific declarations of SIMD math functions for Fortran. -*- f90 -*- >> +! Platform-specific declarations of SIMD math functions for Fortran. > > Let's keep the -*- f90 -*- annotations, they will also be helpful for > future people editing these files. For instance, on my computer, both > emacs and vim use the Fortran syntax highlighting rules for these > files when the annotation is present, and the C rules when it's > absent. > >> + # Skip Fortran header files >> + if 'finclude' in header: >> + continue > > I think this conditional should be > > if header.startswith('finclude/') or '/finclude/' in header > > so that it only applies to headers in the directory 'finclude', not > any hypothetical future headers that happen to have the string > 'finclude' in their base names. (I don't know why that would happen, > but if it ever did, I can see someone being really confused why it > wasn't getting tested, so some extra defensiveness now seems like a > good idea.) I agree. Maybe also add a period to the end of the comment. 8-) Thanks, Florian