From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B92AE1F9FE for ; Mon, 8 Mar 2021 13:30:34 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B33923950C1E; Mon, 8 Mar 2021 13:30:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B33923950C1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1615210233; bh=Ly0WOqh0859Z5xZEhOH70Mmyzw+if7ggVztpJjSqi88=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=w1o/7G3MmU4kFyjZ0Q6wFknbWcNtXZ8mO0ouDl3oUcA8SAKgiM/LXZqyLDZEIZQ/Q XhLiKgknLyKohBk27XHRBWd1WsvSAGLPVsxX6ac/J1lJXDRlIBl4gN/Kvtgoekrnu1 NPABvrC8V8RR+oIlvWD0acMolFQUyvEeJXMHdyTo= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id EA77A3950C1E for ; Mon, 8 Mar 2021 13:30:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EA77A3950C1E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-579-TVOue8KqP_awhZrOGa7mzg-1; Mon, 08 Mar 2021 08:30:29 -0500 X-MC-Unique: TVOue8KqP_awhZrOGa7mzg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 09D0E108BD06; Mon, 8 Mar 2021 13:30:28 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-77.ams2.redhat.com [10.36.112.77]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2BD155C237; Mon, 8 Mar 2021 13:30:26 +0000 (UTC) To: Adhemerval Zanella Subject: Re: [PATCH 02/52] linux: Add futimes test References: <20210305201518.798584-1-adhemerval.zanella@linaro.org> <20210305201518.798584-3-adhemerval.zanella@linaro.org> <87blbx9wdi.fsf@oldenburg.str.redhat.com> <1ffdf637-cf1c-9503-d3d6-a57c57baac08@linaro.org> <878s6xeqt6.fsf@oldenburg.str.redhat.com> Date: Mon, 08 Mar 2021 14:30:31 +0100 In-Reply-To: (Adhemerval Zanella's message of "Mon, 8 Mar 2021 10:26:18 -0300") Message-ID: <874khleps8.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: Adhemerval Zanella via Libc-alpha Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" * Adhemerval Zanella: > On 08/03/2021 10:08, Florian Weimer wrote: >> * Adhemerval Zanella: >> >>> On 05/03/2021 17:30, Florian Weimer wrote: >>>> * Adhemerval Zanella via Libc-alpha: >>>> >>>>> +#define PREPARE do_prepare >>>>> +static void >>>>> +do_prepare (int argc, char *argv[]) >>>>> +{ >>>>> + temp_fd = create_temp_file ("utimes", &testfile); >>>>> + TEST_VERIFY_EXIT (temp_fd > 0); >>>>> +} >>>> >>>> I believe this should use /dev/shm. >>> >>> I still don't this we should gloss over buggy filesystem. >> >> I view this as exactly the same thing as disabling post-Y2038 for 32-bit >> time_t. >> >> We should make it easy for contributors to test their patches. Tests >> where you need to remember why they fail on some systems make this >> difficult. > > On the other hand we are hiding a potentially y2038 issues and > reporting a success that might fail when users do use the interface. I did not suggest to disable the test. I suggested to change so that it uses /dev/shm because tmpfs does not have this problem (and if it does, it can be fixed there by a simple kernel update). Tests for exercising file systems should be maintained in xfstests (which is actually file system independent these days, if I understand it correctly) or LTP. Thanks, Florian