From: Florian Weimer <fweimer@redhat.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3] libio: do not unbuffer legacy standard files in compatibility mode [BZ #24228]
Date: Wed, 13 Mar 2019 16:08:16 +0100 [thread overview]
Message-ID: <8736nqerrz.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20190219012913.GB29070@altlinux.org> (Dmitry V. Levin's message of "Tue, 19 Feb 2019 04:29:13 +0300")
* Dmitry V. Levin:
> Commit glibc-2.23~693 (a601b74d31ca086de38441d316a3dee24c866305)
Please quote the commit hash and commit subject, kernel-style. (How did
you determine this reference, anyway?)
> diff --git a/libio/genops.c b/libio/genops.c
> index 2a0d9b81df..aa92d61b6b 100644
> --- a/libio/genops.c
> +++ b/libio/genops.c
> @@ -789,6 +789,10 @@ _IO_unbuffer_all (void)
>
> for (fp = (FILE *) _IO_list_all; fp; fp = fp->_chain)
> {
> +#if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_1)
> + if (__glibc_unlikely (&_IO_stdin_used == NULL) && _IO_legacy_file (fp))
> + continue;
> +#endif
I wonder if we should check _IO_legacy_file only here. This is related
to the previous discussion.
> diff --git a/libio/tst-bz24228.c b/libio/tst-bz24228.c
> new file mode 100644
> index 0000000000..3692f14b71
> --- /dev/null
> +++ b/libio/tst-bz24228.c
> @@ -0,0 +1,30 @@
> +/* BZ #24228 check for memory corruption in legacy libio
> +
> + Copyright (C) 2019 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
We do not generally have a blank line for the “Copyright” line, I think.
> +#include <mcheck.h>
> +#include <support/test-driver.h>
> +
> +static int
> +do_test (void)
> +{
> + mtrace ();
> + return 0;
> +}
> +
> +#include <support/test-driver.c>
> diff --git a/libio/tst-bz24228.map b/libio/tst-bz24228.map
> new file mode 100644
> index 0000000000..ecb8c058f5
> --- /dev/null
> +++ b/libio/tst-bz24228.map
> @@ -0,0 +1,3 @@
> +{
> + local: _IO_stdin_used;
> +};
Please add a comment to the file why you are doing this, something like
“hide the symbol from libc.so.6 to switch to the libio/oldfileops.c
implementation (if it is available for the architecture)”.
Thanks,
Florian
next prev parent reply other threads:[~2019-03-13 15:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 12:44 [PATCH] libio: do not cleanup wide buffers of legacy standard files [BZ #24228] Dmitry V. Levin
2019-02-18 12:56 ` Florian Weimer
2019-02-18 19:10 ` Dmitry V. Levin
2019-02-18 21:38 ` [PATCH v2] " Dmitry V. Levin
2019-02-19 0:57 ` [PATCH] " Dmitry V. Levin
2019-02-19 1:29 ` [PATCH v3] libio: do not unbuffer legacy standard files in compatibility mode " Dmitry V. Levin
2019-03-13 15:08 ` Florian Weimer [this message]
2019-03-13 15:46 ` Dmitry V. Levin
2019-03-13 15:49 ` Florian Weimer
2019-03-13 15:59 ` Dmitry V. Levin
2019-06-19 13:10 ` Florian Weimer
2019-06-19 16:03 ` Dmitry V. Levin
2019-06-19 16:15 ` Florian Weimer
2019-06-19 17:46 ` Dmitry V. Levin
2019-06-19 19:04 ` Florian Weimer
2019-06-19 19:51 ` [PATCH v4] libio: do not attempt to free wide buffers of legacy streams " Dmitry V. Levin
2019-06-19 21:15 ` Florian Weimer
2019-06-19 22:08 ` [PATCH v5] " Dmitry V. Levin
2019-06-20 8:59 ` Florian Weimer
2019-06-20 17:42 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736nqerrz.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=ldv@altlinux.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).