From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A57971F461 for ; Tue, 16 Jul 2019 11:01:02 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=T7p6M A8G+KWqodTHIrvVn0DE1Z9hX0WAEiWGfO505WEjkwQTxjv2xTVGLjimmMKnSNxqW n2/zfTlWbk8vaT7fP/O2vnuKAPa4W3XO3ptoDLJO8XddcltyuwlKe2SaRhwZkWJq 7iTzY89CdVd7BAjiTpoDfeuLeydvqKymr+2YKY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=be1aJj3AGF3 qYQ3DfxzibBXfZI8=; b=VwhJhXy2+DIiUZEflHGKmphaqOSY+mym52O5w0WwTc4 qBYpy3KelU2pJdB28/P9DDcWvSFtZHamztJxPgXaxMvX3OwIE8sjwYhpDF+8aH5R MEcVRo3mfi8UeEFKJfcsC2zN/xLPQ3hEMgi3NygKJSldJIjfJcDhR70TmuvF5y2g = Received: (qmail 56991 invoked by alias); 16 Jul 2019 11:00:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 56853 invoked by uid 89); 16 Jul 2019 11:00:49 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: Mike Crowe Cc: Adhemerval Zanella , libc-alpha@sourceware.org, Carlos O'Donell Subject: Re: pthread_cond_clockwait glibc forwarder (was Re: [RFCv4] Add pthread_cond_timedwaitonclock_np) References: <20170622170531.1668-1-mac@mcrowe.com> <9ea58c10-ddc7-533e-f477-03e634cb9788@linaro.org> <20170930160124.6il2yexqtv4fojoo@mcrowe.com> <77064c8d-2aa8-4345-0d6d-3a873a5e684f@linaro.org> <20190716100516.fvizo6mhm2hnztxz@mcrowe.com> Date: Tue, 16 Jul 2019 13:00:40 +0200 In-Reply-To: <20190716100516.fvizo6mhm2hnztxz@mcrowe.com> (Mike Crowe's message of "Tue, 16 Jul 2019 11:05:16 +0100") Message-ID: <8736j6kzvr.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain * Mike Crowe: > I was digging through some old review comments, and came across this. It > looks like I didn't address it. :( afe4de7d283ebd88157126c5494ce1796194c16e > added forwarders for __pthread_cond_clockwait and pthread_clock_clockwait > to glibc: > > $ nm /lib64/libc.so.6 |grep _clockwait > 000000000007f410 t __pthread_cond_clockwait > 000000000007f410 t pthread_cond_clockwait > > Should we remove them now, before they are included in a release and it's > too late? (I tried removing them from forward.c, pthread-functions.h and > nptl-init.c and all tests passed on x86_64.) There's no rush because they aren't part of the ABI due to the missing nptl/Versions entry. Therefore, they cannot be used today. Removing them is just an optimization. It's up to Carlos to say whether he wants it in the release. Posting a patch should help with that decision (and since there's no ABI list change involved, the patch can easily be applied after the release if necessary). Thanks, Florian