From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 316611F5AE for ; Fri, 24 Jul 2020 10:30:36 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4C8B6389040E; Fri, 24 Jul 2020 10:30:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4C8B6389040E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1595586635; bh=oHK3z9H3AcBwSULoaVvgl9mA9lSVHJHvU6hSrUiq5f0=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Dp+PDTWF9lVQV7Tzp0JeilQcPJN+3w4mMmTo9nO2XWv41rcbzusNHmOV3aecneUEU Zs5aPtg9dmoC+id8HP4T6dH3Dt5orPrWFup9cZHY+gfTcxXawHJEnPAs6JHSF01OeM 0JjRmLvKVdfUhXl0Vx8JjBGMhuVbd8SZ+8LY8Ydc= Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 0B3AC3857C71 for ; Fri, 24 Jul 2020 10:30:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0B3AC3857C71 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-ZBF8tpPVOiCVFlYJ07GE_w-1; Fri, 24 Jul 2020 06:30:31 -0400 X-MC-Unique: ZBF8tpPVOiCVFlYJ07GE_w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 16A4980183C; Fri, 24 Jul 2020 10:30:30 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-154.ams2.redhat.com [10.36.112.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 43FB05C1BB; Fri, 24 Jul 2020 10:30:29 +0000 (UTC) To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 16/16] linux: Move xmknoda{at} to compat symbols References: <20200723194641.1949404-1-adhemerval.zanella@linaro.org> <20200723194641.1949404-17-adhemerval.zanella@linaro.org> Date: Fri, 24 Jul 2020 12:30:27 +0200 In-Reply-To: <20200723194641.1949404-17-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Thu, 23 Jul 2020 16:46:41 -0300") Message-ID: <87365h9pdo.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: Alistair Francis Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" * Adhemerval Zanella via Libc-alpha: > diff --git a/sysdeps/unix/sysv/linux/mknodat.c b/sysdeps/unix/sysv/linux/mknodat.c > new file mode 100644 > index 0000000000..d160fe520b > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/mknodat.c > @@ -0,0 +1,41 @@ > +int > +__mknodat_common (int fd, const char *path, mode_t mode, dev_t *dev) > +{ > + /* We must convert the value to dev_t type used by the kernel. */ > + unsigned long long int k_dev = (*dev) & ((1ULL << 32) - 1); > + if (k_dev != *dev) > + return INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL); > + > + return INLINE_SYSCALL_CALL (mknodat, fd, path, mode, > + (unsigned int) k_dev); > +} This looks suspicious yo me. Why use a dev_t * argument? Why check against the unsigned long long int value, when the kernel receives an unsigned int value in the system call? What's the intended difference between __mknodat_common and __mknodat? Thanks, Florian