From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id BA8081F8C6 for ; Fri, 9 Jul 2021 06:27:50 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 90F56385482A for ; Fri, 9 Jul 2021 06:27:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 90F56385482A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625812068; bh=TWB0rg8l4bbqqkMtUm/pPPU2xdu+0InCTq4ntSrMwkc=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nsXaco1FXo17ikvsUy8ACgAP2IyTWiCvrrxUSbsVPyq7ro+8BXja4gOC3EqK2mVZx GDxc4ys9YFX2azMZdAH07I+Gt1sUIxpelcjbP9CkGOtikq4QJ5NNmJMmoSs9YbzdWD ybxULVJVp5lVqafTBe6rqK5Cb0BIYF3ImuD+b+PY= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 40BBB385803B for ; Fri, 9 Jul 2021 06:27:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 40BBB385803B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-271-tp1vm82bPeqlRKsZCELfAw-1; Fri, 09 Jul 2021 02:27:25 -0400 X-MC-Unique: tp1vm82bPeqlRKsZCELfAw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B9BAD106B7D6; Fri, 9 Jul 2021 06:27:24 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-103.rdu2.redhat.com [10.10.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 21BD019D9D; Fri, 9 Jul 2021 06:27:19 +0000 (UTC) To: Siddhesh Poyarekar Subject: Re: [PATCH v7 2/8] Remove __morecore and __default_morecore References: <20210708174325.3243721-1-siddhesh@sourceware.org> <20210708174325.3243721-3-siddhesh@sourceware.org> Date: Fri, 09 Jul 2021 08:27:17 +0200 In-Reply-To: <20210708174325.3243721-3-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Thu, 8 Jul 2021 23:13:19 +0530") Message-ID: <8735soknne.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Siddhesh Poyarekar: > diff --git a/malloc/hooks.c b/malloc/hooks.c > index 45c91d6502..4aa6dadcff 100644 > --- a/malloc/hooks.c > +++ b/malloc/hooks.c > @@ -20,6 +20,8 @@ > #if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_34) > void weak_variable (*__after_morecore_hook) (void) = NULL; > compat_symbol (libc, __after_morecore_hook, __after_morecore_hook, GLIBC_2_0); > +void *(*__morecore)(ptrdiff_t); > +compat_symbol (libc, __morecore, __morecore, GLIBC_2_0); > #endif This fails to assemble on ARC (and elsewhere with GCC 9 and earlier): /tmp/ccEXL6bz.s: Assembler messages: /tmp/ccEXL6bz.s: Error: `__morecore@GLIBC_2.32' can't be versioned to common sym bol '__morecore' You need to add __attribute__ ((morecore)). I posted a generic fix for this: Force building with -fno-common But until then, every instance needs to be fixed manually. Thanks, Florian