From: Thomas Gleixner via Libc-alpha <libc-alpha@sourceware.org>
To: "André Almeida" <andrealmeid@collabora.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Darren Hart" <dvhart@infradead.org>,
linux-kernel@vger.kernel.org,
"Steven Rostedt" <rostedt@goodmis.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>
Cc: "Davidlohr Bueso" <dave@stgolabs.net>,
libc-alpha@sourceware.org, linux-api@vger.kernel.org,
mtk.manpages@gmail.com,
"André Almeida" <andrealmeid@collabora.com>,
kernel@collabora.com, krisman@collabora.com
Subject: Re: [PATCH 1/4] futex: Prepare for futex_wait_multiple()
Date: Wed, 18 Aug 2021 10:22:28 +0200 [thread overview]
Message-ID: <8735r72md7.ffs@tglx> (raw)
In-Reply-To: <20210805190405.59110-2-andrealmeid@collabora.com>
Andre,
On Thu, Aug 05 2021 at 16:04, André Almeida wrote:
> +/*
> + * Futex flags used to encode options to functions and preserve them across
> + * restarts.
> + */
> +#ifdef CONFIG_MMU
> +# define FLAGS_SHARED 0x01
> +#else
> +/*
> + * NOMMU does not have per process address space. Let the compiler optimize
> + * code away.
> + */
> +# define FLAGS_SHARED 0x00
> +#endif
> +#define FLAGS_CLOCKRT 0x02
> +#define FLAGS_HAS_TIMEOUT 0x04
> +
> /*
> * Futexes are matched on equal values of this key.
> * The key type depends on whether it's a shared or private mapping.
> @@ -50,8 +66,52 @@ union futex_key {
> } both;
> };
>
> +/**
> + * struct futex_q - The hashed futex queue entry, one per waiting task
> + * @list: priority-sorted list of tasks waiting on this futex
> + * @task: the task waiting on the futex
> + * @lock_ptr: the hash bucket lock
> + * @key: the key the futex is hashed on
> + * @pi_state: optional priority inheritance state
> + * @rt_waiter: rt_waiter storage for use with requeue_pi
> + * @requeue_pi_key: the requeue_pi target futex key
> + * @bitset: bitset for the optional bitmasked wakeup
> + *
> + * We use this hashed waitqueue, instead of a normal wait_queue_entry_t, so
> + * we can wake only the relevant ones (hashed queues may be shared).
> + *
> + * A futex_q has a woken state, just like tasks have TASK_RUNNING.
> + * It is considered woken when plist_node_empty(&q->list) || q->lock_ptr == 0.
> + * The order of wakeup is always to make the first condition true, then
> + * the second.
> + *
> + * PI futexes are typically woken before they are removed from the hash list via
> + * the rt_mutex code. See unqueue_me_pi().
> + */
> +struct futex_q {
> + struct plist_node list;
> +
> + struct task_struct *task;
> + spinlock_t *lock_ptr;
> + union futex_key key;
> + struct futex_pi_state *pi_state;
> + struct rt_mutex_waiter *rt_waiter;
> + union futex_key *requeue_pi_key;
> + u32 bitset;
> +} __randomize_layout;
> +
> #define FUTEX_KEY_INIT (union futex_key) { .both = { .ptr = 0ULL } }
>
> +static const struct futex_q futex_q_init = {
> + /* list gets initialized in queue_me()*/
> + .key = FUTEX_KEY_INIT,
> + .bitset = FUTEX_BITSET_MATCH_ANY
> +};
> +
> +inline struct hrtimer_sleeper *
> +futex_setup_timer(ktime_t *time, struct hrtimer_sleeper *timeout,
> + int flags, u64 range_ns);
> +
None of these things belong into the global header. Please move them to
kernel/futex.h.
Thanks,
tglx
next prev parent reply other threads:[~2021-08-18 8:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 19:04 [PATCH 0/4] futex2: Add wait on multiple futexes syscall André Almeida via Libc-alpha
2021-08-05 19:04 ` [PATCH 1/4] futex: Prepare for futex_wait_multiple() André Almeida via Libc-alpha
2021-08-18 8:22 ` Thomas Gleixner via Libc-alpha [this message]
2021-08-05 19:04 ` [PATCH 2/4] futex2: Implement vectorized wait André Almeida via Libc-alpha
2021-08-18 11:00 ` Thomas Gleixner via Libc-alpha
2021-08-18 16:20 ` Peter Zijlstra
2021-08-18 16:34 ` André Almeida via Libc-alpha
2021-08-18 19:45 ` Thomas Gleixner via Libc-alpha
2021-08-19 3:38 ` André Almeida via Libc-alpha
2021-08-05 19:04 ` [PATCH 3/4] selftests: futex2: Add waitv test André Almeida via Libc-alpha
2021-08-05 19:04 ` [PATCH 4/4] futex2: Documentation: Document futex_waitv() uAPI André Almeida via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735r72md7.ffs@tglx \
--to=libc-alpha@sourceware.org \
--cc=andrealmeid@collabora.com \
--cc=bigeasy@linutronix.de \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).