From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D467A1F4C1 for ; Mon, 28 Nov 2022 10:36:50 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="DJ4JGVHM"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B0CA03858004 for ; Mon, 28 Nov 2022 10:36:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B0CA03858004 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669631808; bh=O/eiG43qik7v0iNOCHMbc+mOQ8vIYdoedmL8lCwBgxo=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=DJ4JGVHMKvUNsqfTyHSr/Z1R+42uQGRYYx4WRvvF+xPPYmz09qdRI9hgoTrBvPbFS B/oidC6DVARm6i4GvXehq+C0Wt4bCumcE687fP1/VlO4kMQQogDplQcYYvap1CxetM SJQxzCO/vhfZuDmkLornb36E+E2/6Uq5DBgowhoQ= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DD9ED385782B for ; Mon, 28 Nov 2022 10:36:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD9ED385782B Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-346-Tw81Q1qJOguNGapJMLZ68w-1; Mon, 28 Nov 2022 05:36:26 -0500 X-MC-Unique: Tw81Q1qJOguNGapJMLZ68w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DB614800B23 for ; Mon, 28 Nov 2022 10:36:25 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 842362027061 for ; Mon, 28 Nov 2022 10:36:25 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH] : Make bsd_signal available with _GNU_SOURCE Date: Mon, 28 Nov 2022 11:36:22 +0100 Message-ID: <8735a3tlg9.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" The declaration does not conflict with anything. This simplifies porting older software to C99 compilers which do not support implicit function declarations and which need -D_GNU_SOURCE for other function declarations. Using __USE_MISC does not seem appropriate here because other systems (e.g., FreeBSD) do not declare bsd_signal. --- signal/signal.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/signal/signal.h b/signal/signal.h index 78d0d819aa..d175d7c3c4 100644 --- a/signal/signal.h +++ b/signal/signal.h @@ -98,7 +98,8 @@ extern __sighandler_t __REDIRECT_NTH (signal, # endif #endif -#if defined __USE_XOPEN_EXTENDED && !defined __USE_XOPEN2K8 +#if (defined __USE_XOPEN_EXTENDED && !defined __USE_XOPEN2K8) \ + || defined __USE_GNU /* The X/Open definition of `signal' conflicts with the BSD version. So they defined another function `bsd_signal'. */ extern __sighandler_t bsd_signal (int __sig, __sighandler_t __handler) base-commit: f704192911c6c7b65a54beab3ab369fca7609a5d