From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id DAE751F44D for ; Fri, 22 Mar 2024 15:52:27 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PdPK/fR8; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 396A2385840E for ; Fri, 22 Mar 2024 15:52:27 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2AB323858D28 for ; Fri, 22 Mar 2024 15:52:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2AB323858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2AB323858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711122728; cv=none; b=HEhCOn5H3AZADDd8Pzhov7SLE1qSuSaV7bODMSI7dXlN78eSIst6+JReM7yjZhR18O1pG/1I5z4WGV7fBB83SLdu9OeTcHMDgb3hEoLNxa7iIbG1FRlIYZMQl+bR59l+Xi9yP7BzyztTSsJCPhguuVq2p/tHSqleDR9OvxmbAAg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711122728; c=relaxed/simple; bh=pR9oNKrkT/SmdIRr1H2TobSp08SFUNtehS0fIb+hoC4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=pjibsJOgH4sud+ekBvu+9p15+M4iJLmZiAgD9du0g/fM9w9O+MtW4zwNDgz+b2sYF5wpBKHoytxpVnJ6Bp4gjpze5mq80OfHbYG1LDEvPMy+l3HEx1H4bK6McUV/cpFO4OBmHgqD5/89aKHa5za59Xw4SmRgfKsBT4a/EGktBoE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711122726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5us9K7KugkTMMhH1efXfQX9ZdUbyaqOPKLRDczBzkhY=; b=PdPK/fR85lJ9h654pn0Va1bo/hJ3ZJhruZwmzzXmwUFXIvxvDFBGmA7wFOLmyv3AT77mzM /aiyZ/CwBkeis3tp2GDUA/RbBKN418A78VRh0J10fpmWqF2EQm/HQxlF2nKuLIu/yLMuq6 YFswMxlx1ODvxsxzTqRNdxVLUIk32dM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-fbaLnqcJPSumXJ10s5ii6Q-1; Fri, 22 Mar 2024 11:52:03 -0400 X-MC-Unique: fbaLnqcJPSumXJ10s5ii6Q-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 642A284B168; Fri, 22 Mar 2024 15:52:03 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 411E2492BD0; Fri, 22 Mar 2024 15:52:02 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Netto Cc: Joseph Myers , libc-alpha@sourceware.org, "H . J . Lu" Subject: Re: [PATCH v2 1/6] math: Add support for auto static math tests In-Reply-To: <152e5240-b315-401a-8bdd-03b4be0fe35f@linaro.org> (Adhemerval Zanella Netto's message of "Fri, 22 Mar 2024 11:14:12 -0300") References: <20240321164325.539976-1-adhemerval.zanella@linaro.org> <20240321164325.539976-2-adhemerval.zanella@linaro.org> <23abf336-5490-d62d-c664-98724630bad0@redhat.com> <87v85edar3.fsf@oldenburg.str.redhat.com> <152e5240-b315-401a-8bdd-03b4be0fe35f@linaro.org> Date: Fri, 22 Mar 2024 16:51:56 +0100 Message-ID: <8734sii7s3.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org * Adhemerval Zanella Netto: > On 22/03/24 03:46, Florian Weimer wrote: >> * Joseph Myers: >> >>> On Thu, 21 Mar 2024, Adhemerval Zanella wrote: >>> >>>> It basically copy the already in place rules for dynamic tests >>>> for auto-generated math tests for all support types. To avoid >>>> the need to duplicate .inc files, a .SECONDEXPANSION rules is >>>> adeed for the gen-libm-test.py generation. >>> >>> Running the autogenerated tests seems overly complicated when the goal is >>> simply to verify that linking a call succeeds. >> >> Right. And I would prefer if we could mark compat/otherwise non-static >> symbols in the ABI lists and use those for testing static linking. >> > > That was my first approach, but then as an experiment I enabled static > build for most of math tests and unexpectedly it has shows some failures > on x86_64: > > FAIL: math/test-float64x-acos > FAIL: math/test-float64x-log10 > FAIL: math/test-float64x-log2 > FAIL: math/test-float64x-y0 > FAIL: math/test-float64x-y1 > FAIL: math/test-ldouble-acos > FAIL: math/test-ldouble-log10 > FAIL: math/test-ldouble-log2 > FAIL: math/test-ldouble-y0 > FAIL: math/test-ldouble-y1 > > $ cat math/test-float64x-acos.out > testing _Float64x (without inline functions) > Failure: acos (max_value): Exception "Overflow" set > Failure: acos (-max_value): Exception "Overflow" set > Failure: acos_downward (max_value): Exception "Overflow" set > Failure: acos_downward (-max_value): Exception "Overflow" set > Failure: acos_towardzero (max_value): Exception "Overflow" set > Failure: acos_towardzero (-max_value): Exception "Overflow" set > Failure: acos_upward (max_value): Exception "Overflow" set > Failure: acos_upward (-max_value): Exception "Overflow" set > > My plan was to eventually track down what might be happening here, and > the currently autogenerated tests gave me a nice scaffolding to add coverage > tests. Interesting. On the other hand, getting --disable-shared to work and just run the *entire* test suite could provide value, too. The last time we discussed this we weren't sure if we had static-specific failures, but your example shows that we do. Thanks, Florian